chrome/browser/ui/views/apps/keyboard_hook_handler.cc - Issue 297123002: API proposal for chrome.app.window to intercept all keys.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/views/apps/keyboard_hook_handler.cc

Issue 297123002: API proposal for chrome.app.window to intercept all keys. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use WidgetObserver instead of plumbing SetKeyboardIntercept through view::Widget Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/views/apps/keyboard_hook_handler.h ('K') | « chrome/browser/ui/views/apps/keyboard_hook_handler.h ('k') | chrome/browser/ui/views/apps/keyboard_hook_handler_win.cc » ('j') | chrome/browser/ui/views/apps/keyboard_hook_handler_win.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
	benwells 2014/11/21 00:52:01 Nit: no (c) Nit: no (c) Sriram 2014/11/21 05:35:21 Done. Show quoted text On 2014/11/21 00:52:01, benwells wrote: > Nit: no (c) Done.
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "chrome/browser/ui/views/apps/keyboard_hook_handler.h"

	6

	7 #include "base/memory/singleton.h"

	8

	9 // TODO(sriramsr): Implement for other platforms.

	10 // Empty implementation for other platform.
	benwells 2014/11/21 00:52:01 Nit: platformS Nit: platformS Sriram 2014/11/21 05:35:21 Done. Show quoted text On 2014/11/21 00:52:01, benwells wrote: > Nit: platformS Done.
	11 void KeyboardHookHandler::Register(views::Widget* widget) {

	12 }

	13

	14 void KeyboardHookHandler::Deregister(views::Widget* widget) {

	15 }

	16

	17 KeyboardHookHandler* KeyboardHookHandler::GetInstance() {
	benwells 2014/11/21 00:52:01 nit: // static on line above. nit: // static on line above. Sriram 2014/11/21 05:35:21 Done. Show quoted text On 2014/11/21 00:52:01, benwells wrote: > nit: // static on line above. Done.
	18 return Singleton<KeyboardHookHandler,

	19 DefaultSingletonTraits<KeyboardHookHandler>>::get();

	20 }

OLD	NEW