chrome/app/generated_resources.grd - Issue 297123002: API proposal for chrome.app.window to intercept all keys.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/generated_resources.grd

Side-by-side diff isn't available for this file because of its large size.

Issue 297123002: API proposal for chrome.app.window to intercept all keys. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update based on sky's comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

« apps/ui/native_app_window.h ('K') | « apps/ui/native_app_window.h ('k') | chrome/browser/apps/app_window_intercept_all_keys_uitest.cc » ('j') | chrome/browser/apps/app_window_intercept_all_keys_uitest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/app/generated_resources.grd

diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd

index da48ed3fac992b2843b4cee1c7ee650475dc3f8f..dead4b83eb1227575f322f040c46ab501e2013ab 100644

--- a/chrome/app/generated_resources.grd

+++ b/chrome/app/generated_resources.grd

@@ -4504,6 +4504,16 @@ Make sure you do not expose any sensitive information.

Monitor when you take actions in Chrome

</message>

+ <if expr="is_macosx">

+ <message name="IDS_EXTENSION_PROMPT_WARNING_INTERCEPT_ALL_KEYS" desc="Permission string for intercept all keyboard keys via packaged app extension APIs">

+ Read and change anything you type including task switching key like CMD+TAB

benwells 2014/08/01 00:32:43 Nit: I think key should be plural

Sriram 2014/08/11 21:01:28 Done.

+ </message>

+ </if>

+ <if expr="not is_macosx">

+ <message name="IDS_EXTENSION_PROMPT_WARNING_INTERCEPT_ALL_KEYS" desc="Permission string for intercept all keyboard keys via packaged app extension APIs">

+ Read and change anything you type including task switching key like ALT+TAB

+ </message>

+ </if>