API proposal for chrome.app.window to intercept all keys.

apps/app_window.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "apps/app_window.h"
 
 #include <algorithm>
 
 #include "apps/app_window_geometry_cache.h"
 #include "apps/app_window_registry.h"
@@ skipping 227 matching lines @@
       extension_id_(extension->id()),
       window_type_(WINDOW_TYPE_DEFAULT),
       delegate_(delegate),
       image_loader_ptr_factory_(this),
       fullscreen_types_(FULLSCREEN_TYPE_NONE),
       show_on_first_paint_(false),
       first_paint_complete_(false),
       has_been_shown_(false),
       can_send_events_(false),
       is_hidden_(false),
-      cached_always_on_top_(false) {
+      cached_always_on_top_(false),
+      cached_want_all_keys_(false) {
   extensions::ExtensionsBrowserClient* client =
       extensions::ExtensionsBrowserClient::Get();
   CHECK(!client->IsGuestSession(context) || context->IsOffTheRecord())
       << "Only off the record window may be opened in the guest mode.";
 }
 
 void AppWindow::Init(const GURL& url,
                      AppWindowContents* app_window_contents,
                      const CreateParams& params) {
   // Initialize the render interface and web contents
@@ skipping 248 matching lines @@
   SaveWindowPosition();
 
 #if defined(OS_WIN)
   if (native_app_window_ && cached_always_on_top_ &&
       !IsFullscreen(fullscreen_types_) && !native_app_window_->IsMaximized() &&
       !native_app_window_->IsMinimized()) {
     UpdateNativeAlwaysOnTop();
   }
 #endif
 
+  UpdateNativeInterceptAllKeys();
+
   if (app_window_contents_ && native_app_window_)
     app_window_contents_->NativeWindowChanged(native_app_window_.get());
 }
 
 void AppWindow::OnNativeWindowActivated() {
   AppWindowRegistry::Get(browser_context_)->AppWindowActivated(this);
 }
 
 content::WebContents* AppWindow::web_contents() const {
   return app_window_contents_->GetWebContents();
@@ skipping 203 matching lines @@
   // overlap the taskbar to be on top. The property will be applied when the
   // window exits fullscreen and moves away from the taskbar.
   if (!IsFullscreen(fullscreen_types_) && !IntersectsWithTaskbar())
     native_app_window_->SetAlwaysOnTop(always_on_top);
 
   OnNativeWindowChanged();
 }
 
 bool AppWindow::IsAlwaysOnTop() const { return cached_always_on_top_; }
 
+void AppWindow::SetInterceptAllKeys(bool want_all_keys) {
+  if (cached_want_all_keys_ == want_all_keys) {
+    return;
+  }
+
+  cached_want_all_keys_ = want_all_keys;
+  UpdateNativeInterceptAllKeys();
+}
+
 void AppWindow::WindowEventsReady() {
   can_send_events_ = true;
   SendOnWindowShownIfShown();
 }
 
 void AppWindow::GetSerializedState(base::DictionaryValue* properties) const {
   DCHECK(properties);
 
   properties->SetBoolean("fullscreen",
                          native_app_window_->IsFullscreenOrPending());
@@ skipping 141 matching lines @@
     // When entering fullscreen or overlapping the taskbar, ensure windows are
     // not always-on-top.
     native_app_window_->SetAlwaysOnTop(false);
   } else if (!is_on_top && !fullscreen && !intersects_taskbar) {
     // When exiting fullscreen and moving away from the taskbar, reinstate
     // always-on-top.
     native_app_window_->SetAlwaysOnTop(true);
   }
 }
 
+void AppWindow::UpdateNativeInterceptAllKeys() {
+  // This function could be called from OnNativeWindowChanged() even before the
+  // object is initialized. So make sure that we have a valid object.
+  if (native_app_window_) {
+    bool should_intercept_all_keys =
+        cached_want_all_keys_ && native_app_window_->IsActive();
+    native_app_window_->SetInterceptAllKeys(should_intercept_all_keys);

[benwells, 2014/07/16 09:39:14]

This is going to be called a lot - e.g. when the window is resized. Should it
just be called when it needs to be set?

[Sriram, 2014/07/24 22:38:54]

Done.

+  }
+}
+
 void AppWindow::SendOnWindowShownIfShown() {
   if (!can_send_events_ || !has_been_shown_)
     return;
 
   if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kTestType)) {
     app_window_contents_->DispatchWindowShownForTests();
   }
 }
 
 void AppWindow::CloseContents(WebContents* contents) {
@@ skipping 231 matching lines @@
         region.bounds.x(),
         region.bounds.y(),
         region.bounds.right(),
         region.bounds.bottom(),
         region.draggable ? SkRegion::kUnion_Op : SkRegion::kDifference_Op);
   }
   return sk_region;
 }
 
 }  // namespace apps