Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1513)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2971163002: Add local protection setting to chrome://settings/system

Created:
3 years, 5 months ago by cfroussios
Modified:
3 years, 5 months ago
Reviewers:
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add local protection setting to chrome://settings/system The setting UI is currently hidden behind the --enable-encryption-selection flag, as is the logic of the setting itself. The setting was introduced in https://codereview.chromium.org/2948783002 BUG=709096 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Patch Set 2 : dep-chain #

Patch Set 3 : cleanup #

Patch Set 4 : linux-only #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -0 lines) Patch
M chrome/browser/resources/settings/system_page/system_page.html View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/system_page/system_page.js View 1 chunk +28 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/system_page/system_page_browser_proxy.js View 2 chunks +27 lines, -0 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/system_handler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/system_handler.cc View 1 2 3 3 chunks +34 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (17 generated)
cfroussios
Description was changed from ========== Add local protection setting to chrome://settings/system The setting UI is ...
3 years, 5 months ago (2017-07-06 15:15:32 UTC) #1
cfroussios
The CQ bit was checked by cfroussios@chromium.org to run a CQ dry run
3 years, 5 months ago (2017-07-06 15:47:52 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2971163002/1
3 years, 5 months ago (2017-07-06 15:48:05 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 5 months ago (2017-07-06 15:57:56 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_headless_rel on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_headless_rel/builds/121001)
3 years, 5 months ago (2017-07-06 15:58:01 UTC) #5
cfroussios
The CQ bit was checked by cfroussios@chromium.org to run a CQ dry run
3 years, 5 months ago (2017-07-07 11:25:14 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2971163002/20001
3 years, 5 months ago (2017-07-07 11:25:22 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 5 months ago (2017-07-07 11:37:32 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_tsan_rel_ng/builds/111252)
3 years, 5 months ago (2017-07-07 11:37:32 UTC) #9
cfroussios
The CQ bit was checked by cfroussios@chromium.org to run a CQ dry run
3 years, 5 months ago (2017-07-07 12:06:32 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2971163002/40001
3 years, 5 months ago (2017-07-07 12:06:44 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 5 months ago (2017-07-07 12:21:57 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/494351)
3 years, 5 months ago (2017-07-07 12:21:59 UTC) #13
cfroussios
The CQ bit was checked by cfroussios@chromium.org to run a CQ dry run
3 years, 5 months ago (2017-07-07 14:14:28 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2971163002/60001
3 years, 5 months ago (2017-07-07 14:14:46 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 5 months ago (2017-07-07 15:17:26 UTC) #16
commit-bot: I haz the power
3 years, 5 months ago (2017-07-07 15:17:27 UTC) #17 
Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Powered by Google App Engine
This is Rietveld 408576698