third_party/WebKit/Source/core/inspector/browser_protocol.json - Issue 2971133002: Add input element values to DOMSnapshot command

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/browser_protocol.json

Issue 2971133002: Add input element values to DOMSnapshot command (Closed)

Patch Set: added additional fields to DomSnapshot::DOMNode Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/inspector/InspectorDOMSnapshotAgent.cpp ('K') | « third_party/WebKit/Source/core/inspector/InspectorDOMSnapshotAgent.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/browser_protocol.json

diff --git a/third_party/WebKit/Source/core/inspector/browser_protocol.json b/third_party/WebKit/Source/core/inspector/browser_protocol.json

index bbafe297d4e2b2f1ea7caefbf93f022155956704..6d41c0a523ab2621b0ad02310a40cb3fc020594d 100644

--- a/third_party/WebKit/Source/core/inspector/browser_protocol.json

+++ b/third_party/WebKit/Source/core/inspector/browser_protocol.json

@@ -3374,6 +3374,10 @@

{ "name": "nodeType", "type": "integer", "description": "<code>Node</code>'s nodeType." },

{ "name": "nodeName", "type": "string", "description": "<code>Node</code>'s nodeName." },

{ "name": "nodeValue", "type": "string", "description": "<code>Node</code>'s nodeValue." },

+ { "name": "textValue", "type": "string", "optional": true, "description": "Only set for textarea elements, contains the text value." },

+ { "name": "inputValue", "type": "string", "optional": true, "description": "Only set for input elements, contains the input's associated text value." },

+ { "name": "inputChecked", "type": "boolean", "optional": true, "description": "Only set for radio and checkbox input elements, indicates if the element has been checked" },

+ { "name": "inputSelected", "type": "boolean", "optional": true, "description": "Only set for option elements, indicates if the element has been selected" },

pfeldman 2017/07/10 19:00:44 I would name this optionSelected, because it is on

dvallet 2017/07/11 00:26:07 Done

{ "name": "backendNodeId", "$ref": "DOM.BackendNodeId", "description": "<code>Node</code>'s id, corresponds to DOM.Node.backendNodeId." },

{ "name": "childNodeIndexes", "type": "array", "items": { "type": "integer" }, "optional": true, "description": "The indexes of the node's child nodes in the <code>domNodes</code> array returned by <code>getSnapshot</code>, if any." },

{ "name": "attributes", "type": "array", "items": { "$ref": "NameValue" }, "optional": true, "description": "Attributes of an <code>Element</code> node." },