Add input element values to DOMSnapshot command

third_party/WebKit/Source/core/inspector/InspectorDOMSnapshotAgent.cpp

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/inspector/InspectorDOMSnapshotAgent.h"
 
+#include "core/InputTypeNames.h"
 #include "core/css/CSSComputedStyleDeclaration.h"
 #include "core/dom/Attribute.h"
 #include "core/dom/AttributeCollection.h"
 #include "core/dom/DOMNodeIds.h"
 #include "core/dom/Document.h"
 #include "core/dom/DocumentType.h"
 #include "core/dom/Element.h"
 #include "core/dom/Node.h"
 #include "core/dom/PseudoElement.h"
 #include "core/dom/QualifiedName.h"
 #include "core/frame/LocalFrame.h"
 #include "core/html/HTMLFrameOwnerElement.h"
+#include "core/html/HTMLInputElement.h"
 #include "core/html/HTMLLinkElement.h"
+#include "core/html/HTMLOptionElement.h"
 #include "core/html/HTMLTemplateElement.h"
+#include "core/html/HTMLTextAreaElement.h"
 #include "core/inspector/IdentifiersFactory.h"
 #include "core/inspector/InspectedFrames.h"
 #include "core/inspector/InspectorDOMAgent.h"
 #include "core/layout/LayoutObject.h"
 #include "core/layout/LayoutText.h"
 #include "core/layout/line/InlineTextBox.h"
 #include "platform/wtf/PtrUtil.h"
 
 namespace blink {
 
@@ skipping 136 matching lines @@
     value->setLayoutNodeIndex(layoutNodeIndex);
 
   if (node->WillRespondToMouseClickEvents())
     value->setIsClickable(true);
 
   if (node->IsElementNode()) {
     Element* element = ToElement(node);
     value->setAttributes(BuildArrayForElementAttributes(element));
 
     if (node->IsFrameOwnerElement()) {
-      HTMLFrameOwnerElement* frame_owner = ToHTMLFrameOwnerElement(node);
+      const HTMLFrameOwnerElement* frame_owner = ToHTMLFrameOwnerElement(node);
       if (LocalFrame* frame =
               frame_owner->ContentFrame() &&
                       frame_owner->ContentFrame()->IsLocalFrame()
                   ? ToLocalFrame(frame_owner->ContentFrame())
                   : nullptr) {
         value->setFrameId(IdentifiersFactory::FrameId(frame));
       }
       if (Document* doc = frame_owner->contentDocument()) {
         value->setContentDocumentIndex(VisitNode(doc));
       }
     }
 
     if (node->parentNode() && node->parentNode()->IsDocumentNode()) {
       LocalFrame* frame = node->GetDocument().GetFrame();
       if (frame)
         value->setFrameId(IdentifiersFactory::FrameId(frame));
     }
 
     if (isHTMLLinkElement(*element)) {
-      HTMLLinkElement& link_element = toHTMLLinkElement(*element);
+      const HTMLLinkElement& link_element = toHTMLLinkElement(*element);
       if (link_element.IsImport() && link_element.import() &&
           InspectorDOMAgent::InnerParentNode(link_element.import()) ==
               link_element) {
         value->setImportedDocumentIndex(VisitNode(link_element.import()));
       }
     }
 
     if (isHTMLTemplateElement(*element)) {
       value->setTemplateContentIndex(
           VisitNode(toHTMLTemplateElement(*element).content()));
     }
 
+    if (isHTMLTextAreaElement(*element)) {
+      const HTMLTextAreaElement& text_area_element =
+          toHTMLTextAreaElement(*element);
+      if (!text_area_element.value().IsEmpty())

[pfeldman, 2017/07/10 19:00:44]

I think you should set it regardless, it can be important to know the empty
input value.

[dvallet, 2017/07/11 00:26:07]

Done.

+        value->setTextValue(text_area_element.value());
+    }
+
+    if (isHTMLInputElement(*element)) {
+      const HTMLInputElement& input_element = toHTMLInputElement(*element);
+      if (!input_element.value().IsEmpty())
+        value->setInputValue(input_element.value());

[pfeldman, 2017/07/10 19:00:44]

I would put it into the else branch and also not check for empty.

[dvallet, 2017/07/11 00:26:07]

Radio and checkbox elements can have also values associated, wouldn't we want to
include this? E.g, 
<form>
  <input type="radio" name="gender" value="male" checked> Male<br>
  <input type="radio" name="gender" value="female"> Female<br>
  <input type="radio" name="gender" value="other"> Other
</form>

+      if ((input_element.type() == InputTypeNames::radio) ||
+          (input_element.type() == InputTypeNames::checkbox)) {
+        value->setInputChecked(input_element.checked());
+      }
+    }
+
+    if (isHTMLOptionElement(*element)) {
+      const HTMLOptionElement& option_element = toHTMLOptionElement(*element);
+      value->setInputSelected(option_element.Selected());
+    }
+
     if (element->GetPseudoId()) {
       protocol::DOM::PseudoType pseudo_type;
       if (InspectorDOMAgent::GetPseudoElementType(element->GetPseudoId(),
                                                   &pseudo_type)) {
         value->setPseudoType(pseudo_type);
       }
     } else {
       value->setPseudoElementIndexes(VisitPseudoElements(element));
     }
   } else if (node->IsDocumentNode()) {
@@ skipping 156 matching lines @@
   computed_styles_map_->insert(std::move(style), index);
   return index;
 }
 
 DEFINE_TRACE(InspectorDOMSnapshotAgent) {
   visitor->Trace(inspected_frames_);
   InspectorBaseAgent::Trace(visitor);
 }
 
 }  // namespace blink