Add input element values to DOMSnapshot command

third_party/WebKit/Source/core/inspector/InspectorDOMSnapshotAgent.cpp

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/inspector/InspectorDOMSnapshotAgent.h"
 
+#include "core/InputTypeNames.h"
 #include "core/css/CSSComputedStyleDeclaration.h"
 #include "core/dom/Attribute.h"
 #include "core/dom/AttributeCollection.h"
 #include "core/dom/DOMNodeIds.h"
 #include "core/dom/Document.h"
 #include "core/dom/DocumentType.h"
 #include "core/dom/Element.h"
 #include "core/dom/Node.h"
 #include "core/dom/PseudoElement.h"
 #include "core/dom/QualifiedName.h"
 #include "core/frame/LocalFrame.h"
 #include "core/html/HTMLFrameOwnerElement.h"
+#include "core/html/HTMLInputElement.h"
 #include "core/html/HTMLLinkElement.h"
+#include "core/html/HTMLOptionElement.h"
 #include "core/html/HTMLTemplateElement.h"
+#include "core/html/HTMLTextAreaElement.h"
 #include "core/inspector/IdentifiersFactory.h"
 #include "core/inspector/InspectedFrames.h"
 #include "core/inspector/InspectorDOMAgent.h"
 #include "core/layout/LayoutObject.h"
 #include "core/layout/LayoutText.h"
 #include "core/layout/line/InlineTextBox.h"
 #include "platform/wtf/PtrUtil.h"
 
 namespace blink {
 
@@ skipping 169 matching lines @@
               link_element) {
         value->setImportedDocumentIndex(VisitNode(link_element.import()));
       }
     }
 
     if (isHTMLTemplateElement(*element)) {
       value->setTemplateContentIndex(
           VisitNode(toHTMLTemplateElement(*element).content()));
     }
 
+    if (isHTMLTextAreaElement(*element)) {
+      HTMLTextAreaElement& text_area_element = toHTMLTextAreaElement(*element);

[alex clarke (OOO till 29th), 2017/07/06 07:48:18]

Lets make all these references const.

[dvallet, 2017/07/07 04:51:39]

Done

+      if (!text_area_element.value().IsEmpty())
+        value->setNodeValue(text_area_element.value());
+    }
+
+    if (isHTMLInputElement(*element)) {
+      HTMLInputElement& input_element = toHTMLInputElement(*element);
+      String input_value = input_element.value();

[alex clarke (OOO till 29th), 2017/07/06 07:48:18]

You can probably use std::move here

[dvallet, 2017/07/07 04:51:39]

I think it already does copy elision, If I add std::move I get: 
 error: moving a temporary object prevents copy elision

+      if ((input_element.type() == InputTypeNames::radio) ||
+          (input_element.type() == InputTypeNames::checkbox)) {
+        if (input_element.checked())
+          input_value = "checked";

[alex clarke (OOO till 29th), 2017/07/06 07:48:18]

I believe the style guide wants us to use brackets for if then else statements.

[dvallet, 2017/07/07 04:51:39]

Done

+        else
+          input_value = "";
+      }
+      if (!input_value.IsEmpty())
+        value->setNodeValue(input_value);
+    }
+
+    if (isHTMLOptionElement(*element)) {
+      HTMLOptionElement& option_element = toHTMLOptionElement(*element);
+      if (option_element.Selected()) {
+        value->setNodeValue("selected");

[Eric Seckler, 2017/07/06 07:41:39]

Nit: no need for {}.

[dvallet, 2017/07/07 04:51:39]

Done

+      }
+    }
+
     if (element->GetPseudoId()) {
       protocol::DOM::PseudoType pseudo_type;
       if (InspectorDOMAgent::GetPseudoElementType(element->GetPseudoId(),
                                                   &pseudo_type)) {
         value->setPseudoType(pseudo_type);
       }
     } else {
       value->setPseudoElementIndexes(VisitPseudoElements(element));
     }
   } else if (node->IsDocumentNode()) {
@@ skipping 156 matching lines @@
   computed_styles_map_->insert(std::move(style), index);
   return index;
 }
 
 DEFINE_TRACE(InspectorDOMSnapshotAgent) {
   visitor->Trace(inspected_frames_);
   InspectorBaseAgent::Trace(visitor);
 }
 
 }  // namespace blink