Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Unified Diff: ios/clean/chrome/browser/ui/tab_collection/tab_collection_mediator_unittest.mm

Issue 2971093002: [ios] Take snapshot for tab grid. (Closed)
Patch Set: Update unit test. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/clean/chrome/browser/ui/tab_collection/tab_collection_mediator_unittest.mm
diff --git a/ios/clean/chrome/browser/ui/tab_collection/tab_collection_mediator_unittest.mm b/ios/clean/chrome/browser/ui/tab_collection/tab_collection_mediator_unittest.mm
index 2a746413aea183f95c84dd62a6611e9731e3f352..a9f98dfde4c5079741332f07e2530028705ee706 100644
--- a/ios/clean/chrome/browser/ui/tab_collection/tab_collection_mediator_unittest.mm
+++ b/ios/clean/chrome/browser/ui/tab_collection/tab_collection_mediator_unittest.mm
@@ -5,6 +5,7 @@
#import "ios/clean/chrome/browser/ui/tab_collection/tab_collection_mediator.h"
#include "base/memory/ptr_util.h"
+#import "ios/chrome/browser/snapshots/snapshot_cache.h"
#import "ios/chrome/browser/web/tab_id_tab_helper.h"
#include "ios/chrome/browser/web_state_list/fake_web_state_list_delegate.h"
#include "ios/chrome/browser/web_state_list/web_state_list.h"
@@ -95,5 +96,23 @@ TEST_F(TabCollectionMediatorTest, TestDetachWebState) {
// webStateList.
TEST_F(TabCollectionMediatorTest, TestChangeActiveWebState) {
web_state_list_->ActivateWebStateAt(2);
- [[consumer_ verify] setSelectedIndex:2];
+ // Due to use of id for OCMock objects, naming collisions can exist. In this
+ // case, the method -setSelectedIndex: collides with a property setter in
+ // UIKit's UITabBarController class. The fix is to cast after calling -verify.
+ auto consumer = static_cast<id<TabCollectionConsumer>>([consumer_ verify]);
+ [consumer setSelectedIndex:2];
+}
+
+// Tests that the consumer is notified that a snapshot has been updated.
+TEST_F(TabCollectionMediatorTest, TestTakeSnapshot) {
+ web::TestWebState* web_state = GetWebStateAt(0);
+ TabIdTabHelper::CreateForWebState(web_state);
+ TabIdTabHelper* tab_helper = TabIdTabHelper::FromWebState(web_state);
+ NSString* tab_id = tab_helper->tab_id();
+
+ id snapshot_cache = OCMClassMock([SnapshotCache class]);
+ [mediator_ takeSnapshotWithCache:snapshot_cache];
+
+ [[snapshot_cache verify] setImage:[OCMArg any] withSessionID:tab_id];
+ [[consumer_ verify] updateSnapshotAtIndex:0];
}

Powered by Google App Engine
This is Rietveld 408576698