Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3433)

Unified Diff: base/android/java/src/org/chromium/base/JavaExceptionReporter.java

Issue 2971063003: Handle Java assert using a customized function in base (Closed)
Patch Set: fix tests Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/BUILD.gn ('k') | base/android/java/src/org/chromium/base/process_launcher/ChildProcessLauncher.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/android/java/src/org/chromium/base/JavaExceptionReporter.java
diff --git a/base/android/java/src/org/chromium/base/JavaExceptionReporter.java b/base/android/java/src/org/chromium/base/JavaExceptionReporter.java
index f192f78c10472d0055128700883aa9b019ff7837..80b840cf2f27dd16ea4fd04ccf76d4da1be9465c 100644
--- a/base/android/java/src/org/chromium/base/JavaExceptionReporter.java
+++ b/base/android/java/src/org/chromium/base/JavaExceptionReporter.java
@@ -9,6 +9,7 @@ import android.support.annotation.UiThread;
import org.chromium.base.annotations.CalledByNative;
import org.chromium.base.annotations.JNINamespace;
import org.chromium.base.annotations.MainDex;
+import org.chromium.buildhooks.Callback;
/**
* This UncaughtExceptionHandler will create a breakpad minidump when there is an uncaught
@@ -54,6 +55,16 @@ public class JavaExceptionReporter implements Thread.UncaughtExceptionHandler {
nativeReportJavaStackTrace(stackTrace);
}
+ /**
+ * This class will be passed in ChromeApplication that handlers all AssertionError.
+ */
+ public static class AssertFailureCallback implements Callback<AssertionError> {
+ @Override
+ public void run(AssertionError assertionError) {
+ throw assertionError;
+ }
+ }
+
@CalledByNative
private static void installHandler(boolean crashAfterReport) {
Thread.setDefaultUncaughtExceptionHandler(new JavaExceptionReporter(
« no previous file with comments | « base/BUILD.gn ('k') | base/android/java/src/org/chromium/base/process_launcher/ChildProcessLauncher.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698