Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4202)

Unified Diff: base/android/java/src/org/chromium/base/JavaExceptionReporter.java

Issue 2971063003: Handle Java assert using a customized function in base (Closed)
Patch Set: just refactor, do not report exception Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/android/java/src/org/chromium/base/JavaExceptionReporter.java
diff --git a/base/android/java/src/org/chromium/base/JavaExceptionReporter.java b/base/android/java/src/org/chromium/base/JavaExceptionReporter.java
index f192f78c10472d0055128700883aa9b019ff7837..118810fba2b785107c034a74d1cc09aee1748534 100644
--- a/base/android/java/src/org/chromium/base/JavaExceptionReporter.java
+++ b/base/android/java/src/org/chromium/base/JavaExceptionReporter.java
@@ -54,6 +54,14 @@ public class JavaExceptionReporter implements Thread.UncaughtExceptionHandler {
nativeReportJavaStackTrace(stackTrace);
}
+ /**
+ * Handle AssertionError, decide whether throw or report without crashing base on gn arg.
+ *
agrieve 2017/07/07 18:42:42 nit: delete blank line
Ran 2017/07/17 21:46:52 Done.
+ */
+ public static void assertFailureHandler(AssertionError assertionError) throws AssertionError {
+ throw assertionError;
+ }
+
@CalledByNative
private static void installHandler(boolean crashAfterReport) {
Thread.setDefaultUncaughtExceptionHandler(new JavaExceptionReporter(
« no previous file with comments | « no previous file | build/android/java_assertion_enabler/OWNERS » ('j') | build/android/java_assertion_enabler/OWNERS » ('J')

Powered by Google App Engine
This is Rietveld 408576698