Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2971063002: Issue 30006. Don't flush on write to FileByteStore. (Closed)

Created:
3 years, 5 months ago by scheglov
Modified:
3 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Issue 30006. Don't flush on write to FileByteStore. It turned out to be too expensive for some users. R=brianwilkerson@google.com BUG= https://github.com/dart-lang/sdk/issues/30006 Committed: https://github.com/dart-lang/sdk/commit/1bb532d854d7863d68122952f6921035e33beef1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pkg/front_end/lib/src/incremental/file_byte_store.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 5 months ago (2017-07-05 22:18:22 UTC) #1
Brian Wilkerson
lgtm
3 years, 5 months ago (2017-07-05 22:25:42 UTC) #2
scheglov
3 years, 5 months ago (2017-07-05 22:33:35 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1bb532d854d7863d68122952f6921035e33beef1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698