Source/core/dom/Document.cpp - Issue 297103002: Move modules-dependent Event code out of core.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Document.cpp

Issue 297103002: Move modules-dependent Event code out of core. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebaseline Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/Document.cpp

diff --git a/Source/core/dom/Document.cpp b/Source/core/dom/Document.cpp

index d15908211b4b57fcda2a9368ec2579faf56e2dfc..52b09cdc396be07ce0b52c47f44fd8b27e2e758a 100644

--- a/Source/core/dom/Document.cpp

+++ b/Source/core/dom/Document.cpp

@@ -3909,9 +3909,6 @@ PassRefPtrWillBeRawPtr<Event> Document::createEvent(const String& eventType, Exc

RefPtrWillBeRawPtr<Event> event = EventFactory::create(eventType);

if (event)

return event.release();

- event = EventModulesFactory::create(eventType); // TODO: move this to modules http://crbug.com/358074

- if (event)

- return event.release();

exceptionState.throwDOMException(NotSupportedError, "The provided event type ('" + eventType + "') is invalid.");

return nullptr;