Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2970983003: modifiy insertTokenBefore to return the inserted token (Closed)

Created:
3 years, 5 months ago by danrubel
Modified:
3 years, 5 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

modifiy insertTokenBefore to return the inserted token R=paulberry@google.com Committed: https://github.com/dart-lang/sdk/commit/bf2b3e7061d7e66e5c3c45d5f143118a9d3edb67

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M pkg/front_end/lib/src/fasta/parser/token_stream_rewriter.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/front_end/test/fasta/parser/token_stream_rewriter_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
3 years, 5 months ago (2017-07-05 19:40:22 UTC) #2
Paul Berry
lgtm
3 years, 5 months ago (2017-07-05 19:43:23 UTC) #3
danrubel
3 years, 5 months ago (2017-07-05 19:50:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bf2b3e7061d7e66e5c3c45d5f143118a9d3edb67 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698