Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1028)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2970943002: Use index in J/KTypeVariable and fix remaining inequivalence (Closed)

Created:
3 years, 5 months ago by Johnni Winther
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use index in J/KTypeVariable and fix remaining inequivalence R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/edbc13bac6fc480499f39d085a435b0ce2f68a81

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comments. #

Patch Set 3 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -55 lines) Patch
M pkg/compiler/lib/src/common_elements.dart View 2 chunks +12 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 2 chunks +0 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/js_model/elements.dart View 3 chunks +7 lines, -33 lines 0 comments Download
M pkg/compiler/lib/src/kernel/element_map_impl.dart View 1 2 8 chunks +44 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/kernel/elements.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kelements.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/js_model/model_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Johnni Winther
3 years, 5 months ago (2017-07-05 11:25:23 UTC) #3
Siggi Cherem (dart-lang)
https://codereview.chromium.org/2970943002/diff/1/pkg/compiler/lib/src/kernel/element_map_impl.dart File pkg/compiler/lib/src/kernel/element_map_impl.dart (right): https://codereview.chromium.org/2970943002/diff/1/pkg/compiler/lib/src/kernel/element_map_impl.dart#newcode1783 pkg/compiler/lib/src/kernel/element_map_impl.dart:1783: typeVariableIndex++) {} missing body? don't we need to convert ...
3 years, 5 months ago (2017-07-05 21:35:38 UTC) #4
Johnni Winther
PTAL https://codereview.chromium.org/2970943002/diff/1/pkg/compiler/lib/src/kernel/element_map_impl.dart File pkg/compiler/lib/src/kernel/element_map_impl.dart (right): https://codereview.chromium.org/2970943002/diff/1/pkg/compiler/lib/src/kernel/element_map_impl.dart#newcode1783 pkg/compiler/lib/src/kernel/element_map_impl.dart:1783: typeVariableIndex++) {} On 2017/07/05 21:35:37, Siggi Cherem (dart-lang) ...
3 years, 5 months ago (2017-07-06 15:05:46 UTC) #5
Siggi Cherem (dart-lang)
lgtm
3 years, 5 months ago (2017-07-06 17:48:33 UTC) #6
Johnni Winther
3 years, 5 months ago (2017-07-07 08:30:32 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
edbc13bac6fc480499f39d085a435b0ce2f68a81 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698