Issue 297093002: MIPS: Fix r21470 “Reland r21442 Inobject slack tracking is done on a per-closure basis instead of p…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 297093002: MIPS: Fix r21470 “Reland r21442 Inobject slack tracking is done on a per-closure basis instead of p… (Closed)

Created:
6 years, 7 months ago by kilvadyb

Modified:
6 years, 7 months ago

Reviewers:
Igor Sheludko, Paul Lind, danno, kisg, palfia, dusmil

CC:
v8-dev

Base URL:
git@github.com:paul99/v8m-rb.git@master

Visibility:
Public.

More Reviews

Description

MIPS: Fix r21470 “Reland r21442 Inobject slack tracking is done on a per-closure basis instead of per-shared info basis." BUG=

Patch Set 2 : Fix nit. #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -3 lines)			Patch
	M	src/mips/builtins-mips.cc	View	1	3 chunks	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Paul Lind

https://codereview.chromium.org/297093002/diff/1/src/mips/builtins-mips.cc File src/mips/builtins-mips.cc (right): https://codereview.chromium.org/297093002/diff/1/src/mips/builtins-mips.cc#newcode400 src/mips/builtins-mips.cc:400: __ mov(t2, zero_reg); Can we add a comment here: ...

6 years, 7 months ago (2014-05-23 19:18:05 UTC) #2

kilvadyb

6 years, 7 months ago (2014-05-23 19:30:38 UTC) #3

Committed as r21471.

Expand Messages | Collapse Messages

Issue 297093002: MIPS: Fix r21470 “Reland r21442 Inobject slack tracking is done on a per-closure basis instead of p… (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix nit. #

Messages