Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: ios/chrome/browser/ui/webui/flags_ui.h

Issue 2970863002: Removing ui-alternatives (Closed)
Patch Set: more removal Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/webui/flags_ui.h
diff --git a/ios/chrome/browser/ui/webui/flags_ui.h b/ios/chrome/browser/ui/webui/flags_ui.h
index 3a4492ffbdaf4f8fc2dc087f60c711053eb2f043..fd46f304b0a2c38f8bd8d80d0534f8ca976b4f1e 100644
--- a/ios/chrome/browser/ui/webui/flags_ui.h
+++ b/ios/chrome/browser/ui/webui/flags_ui.h
@@ -9,40 +9,14 @@
#include "base/memory/weak_ptr.h"
#include "ios/web/public/webui/web_ui_ios_controller.h"
-class BaseFlagsUI : public web::WebUIIOSController {
+class FlagsUI : public web::WebUIIOSController {
public:
- enum FlagsUIKind {
- FLAGS_UI_GENERIC,
- FLAGS_UI_APPLE,
- };
-
- BaseFlagsUI(web::WebUIIOS* web_ui, FlagsUIKind flags_ui_kind);
- ~BaseFlagsUI() override;
-
- private:
- void Initialize(web::WebUIIOS* web_ui, FlagsUIKind flags_ui_kind);
-
- base::WeakPtrFactory<BaseFlagsUI> weak_factory_;
-
- DISALLOW_COPY_AND_ASSIGN(BaseFlagsUI);
-};
-
-class FlagsUI : public BaseFlagsUI {
- public:
- explicit FlagsUI(web::WebUIIOS* web_ui);
+ FlagsUI(web::WebUIIOS* web_ui);
sdefresne 2017/07/04 12:45:25 This needs an explicit: explicit FlagsUO(web::W
noyau (Ping after 24h) 2017/07/06 09:53:55 Yes, good catch. Done.
~FlagsUI() override;
private:
+ base::WeakPtrFactory<FlagsUI> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(FlagsUI);
};
-class AppleFlagsUI : public BaseFlagsUI {
- public:
- explicit AppleFlagsUI(web::WebUIIOS* web_ui);
- ~AppleFlagsUI() override;
-
- private:
- DISALLOW_COPY_AND_ASSIGN(AppleFlagsUI);
-};
-
#endif // IOS_CHROME_BROWSER_UI_WEBUI_FLAGS_UI_H_

Powered by Google App Engine
This is Rietveld 408576698