Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2970783002: (CANCELED) [LayoutNG] Fix block child iteration in NGBlockLayoutAlgorithm::ComputeMinMaxContentSize (Closed)

Created:
3 years, 5 months ago by kojii
Modified:
3 years, 5 months ago
Reviewers:
CC:
atotic+reviews_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, cbiesinger, chromium-reviews, dgrogan+ng_chromium.org, eae+blinkwatch, glebl+reviews_chromium.org, jchaffraix+rendering, lchoi+reviews_chromium.org, leviw+renderwatch, ojan+watch_chromium.org, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Canceled -- more proper fix in https://chromium-review.googlesource.com/c/566984/ [LayoutNG] Fix block child iteration in NGBlockLayoutAlgorithm::ComputeMinMaxContentSize This patch fixes NGBlockLayoutAlgorithm::ComputeMinMaxContentSize() to iterate all block children. Before this change, it finds only 1st child if the 1st child is a block with inline children. The root cause is in bug 739087, but using NGBlockChildIterator to iterate block children looks right. Simpler repro: <!DOCTYPE html> <style> min-content { display: block; width: min-content; border: solid orange; } </style> <min-content><div>x</div><div>bcd</div></min-content> BUG=636993, 739087 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (6 generated)
kojii
Description was changed from ========== preferred-width BUG= ========== to ========== preferred-width BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng ==========
3 years, 5 months ago (2017-07-04 06:44:10 UTC) #1
kojii
Description was changed from ========== preferred-width BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng ========== to ========== [LayoutNG] Fix block child ...
3 years, 5 months ago (2017-07-04 06:54:29 UTC) #2
kojii
Description was changed from ========== [LayoutNG] Fix block child iteration in NGBlockLayoutAlgorithm::ComputeMinMaxContentSize This patch fixes ...
3 years, 5 months ago (2017-07-04 06:57:40 UTC) #3
kojii
Description was changed from ========== [LayoutNG] Fix block child iteration in NGBlockLayoutAlgorithm::ComputeMinMaxContentSize This patch fixes ...
3 years, 5 months ago (2017-07-04 06:59:43 UTC) #4
kojii
Description was changed from ========== [LayoutNG] Fix block child iteration in NGBlockLayoutAlgorithm::ComputeMinMaxContentSize This patch fixes ...
3 years, 5 months ago (2017-07-04 07:36:38 UTC) #5
kojii
3 years, 5 months ago (2017-07-12 05:05:32 UTC) #6 
Description was changed from

==========
[LayoutNG] Fix block child iteration in
NGBlockLayoutAlgorithm::ComputeMinMaxContentSize

This patch fixes NGBlockLayoutAlgorithm::ComputeMinMaxContentSize() to
iterate all block children. Before this change, it finds only 1st child
if the 1st child is a block with inline children.

The root cause is in bug 739087, but using NGBlockChildIterator to
iterate block children looks right.

Simpler repro:

<!DOCTYPE html>
<style>
min-content {
  display: block;
  width: min-content;
  border: solid orange;
}
</style>
<min-content><div>x</div><div>bcd</div></min-content>

BUG=636993, 739087
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

to

==========
Canceled -- more proper fix in
https://chromium-review.googlesource.com/c/566984/

[LayoutNG] Fix block child iteration in
NGBlockLayoutAlgorithm::ComputeMinMaxContentSize

This patch fixes NGBlockLayoutAlgorithm::ComputeMinMaxContentSize() to
iterate all block children. Before this change, it finds only 1st child
if the 1st child is a block with inline children.

The root cause is in bug 739087, but using NGBlockChildIterator to
iterate block children looks right.

Simpler repro:

<!DOCTYPE html>
<style>
min-content {
  display: block;
  width: min-content;
  border: solid orange;
}
</style>
<min-content><div>x</div><div>bcd</div></min-content>

BUG=636993, 739087
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

Powered by Google App Engine
This is Rietveld 408576698