Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2970733002: test.py: temporarily disable background optimizer in vm-dartk-debug config. (Closed)

Created:
3 years, 5 months ago by Vyacheslav Egorov (Google)
Modified:
3 years, 5 months ago
Reviewers:
ahe, kustermann
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

test.py: temporarily disable background optimizer in vm-dartk-debug config. It is causing flakiness on bots. Unmark tests marked as flaky by 45e4d848d2ac492cecb9057dbc38e4f3764443b7 See https://github.com/dart-lang/sdk/issues/30016. BUG= R=kustermann@google.com Committed: https://github.com/dart-lang/sdk/commit/f167ad18da6161b3cfcca1f22109bb113e30519a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M tests/co19/co19-kernel.status View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language/language_kernel.status View 1 chunk +0 lines, -1 line 0 comments Download
M tools/testing/dart/compiler_configuration.dart View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Vyacheslav Egorov (Google)
PTAL
3 years, 5 months ago (2017-07-03 14:43:36 UTC) #2
kustermann
lgtm
3 years, 5 months ago (2017-07-03 14:52:00 UTC) #3
kustermann
Maybe bump the bug to be high-priority, since this will mask any new bg compiler ...
3 years, 5 months ago (2017-07-03 14:53:15 UTC) #4
Vyacheslav Egorov (Google)
3 years, 5 months ago (2017-07-03 15:05:16 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f167ad18da6161b3cfcca1f22109bb113e30519a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698