ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.h - Issue 2970703002: Change GetAccessToken APIs so that they don't pass const ref to blocks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.h

Issue 2970703002: Change GetAccessToken APIs so that they don't pass const ref to blocks. (Closed)

Patch Set: Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/public/provider/chrome/browser/signin/chrome_identity_service.mm ('k') | ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.h

diff --git a/ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.h b/ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.h

index 7f9e7c907cf85d5c4c135cf98b6a13f376dedb69..b9971fbc43624d78f5125ced5dd31b7991a7242b 100644

--- a/ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.h

+++ b/ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.h

@@ -41,12 +41,11 @@ class FakeChromeIdentityService : public ChromeIdentityService {

void ForgetIdentity(ChromeIdentity* identity,

ForgetIdentityCallback callback) override;

- virtual void GetAccessToken(

- ChromeIdentity* identity,

- const std::string& client_id,

- const std::string& client_secret,

- const std::set<std::string>& scopes,

- const ios::AccessTokenCallback& callback) override;

+ virtual void GetAccessToken(ChromeIdentity* identity,

+ const std::string& client_id,

+ const std::string& client_secret,

+ const std::set<std::string>& scopes,

+ ios::AccessTokenCallback callback) override;

virtual void GetAvatarForIdentity(ChromeIdentity* identity,

GetAvatarCallback callback) override;