(NO NEED REVIEW) loading spinner background for bookmarks panel (iOS)

No need review.  This is an experiment CL.
Show a loading spinner on bookmarks panel when syncing.

BUG=696893

[Marti Wong, 2017-07-05 05:57:00]

martiw@chromium.org changed reviewers:
+ ramyasharma@chromium.org

[Marti Wong, 2017-07-05 05:57:02]

https://codereview.chromium.org/2970693004/diff/1/ios/chrome/browser/ui/bookm...
File ios/chrome/browser/ui/bookmarks/bookmark_collection_view.mm (left):

https://codereview.chromium.org/2970693004/diff/1/ios/chrome/browser/ui/bookm...
ios/chrome/browser/ui/bookmarks/bookmark_collection_view.mm:82: const
NSTimeInterval kShowEmptyBookmarksBackgroundRefreshDelay = 1.0;
This is no longer needed.
we will be notified by SyncedSessionsObserver when syncing is finished.

https://codereview.chromium.org/2970693004/diff/1/ios/chrome/browser/ui/bookm...
File ios/chrome/browser/ui/bookmarks/bookmark_collection_view.mm (right):

https://codereview.chromium.org/2970693004/diff/1/ios/chrome/browser/ui/bookm...
ios/chrome/browser/ui/bookmarks/bookmark_collection_view.mm:235: [self
initObserver];
learnt from recent_tabs_panel_controller.mm

https://codereview.chromium.org/2970693004/diff/1/ios/chrome/browser/ui/bookm...
ios/chrome/browser/ui/bookmarks/bookmark_collection_view.mm:255: [self
deallocObserver];
learnt from recent_tabs_panel_controller.mm

https://codereview.chromium.org/2970693004/diff/1/ios/chrome/browser/ui/bookm...
ios/chrome/browser/ui/bookmarks/bookmark_collection_view.mm:653: 
2 functions below are copied from recent_tabs_panel_controller.mm

https://codereview.chromium.org/2970693004/diff/1/ios/chrome/browser/ui/bookm...
ios/chrome/browser/ui/bookmarks/bookmark_collection_view.mm:928: [self
showLoadingSpinnerBackground];
the spinnerbackground will be hidden at onSyncStateChanged (at the bottom of
this file).

https://codereview.chromium.org/2970693004/diff/1/ios/chrome/browser/ui/bookm...
ios/chrome/browser/ui/bookmarks/bookmark_collection_view.mm:962:
BookmarkHomeWaitingView* loadingSpinnerBackgroundView =
Should I reuse BookmarkHomeWaitingView or we need to create a new class for the
spinner background?
The usage of BookmarkHomeWaitingView here is copied from
bookmark_home_handset_view_controller.mm

or please advise if we should use other kind of spinner.

https://codereview.chromium.org/2970693004/diff/1/ios/chrome/browser/ui/bookm...
ios/chrome/browser/ui/bookmarks/bookmark_collection_view.mm:972:
self.collectionView.backgroundView = self.loadingSpinnerBackgroundView;
self.collectionView.backgroundView  was  = self.emptyCollectionBackgroundView;

https://codereview.chromium.org/2970693004/diff/1/ios/chrome/browser/ui/bookm...
ios/chrome/browser/ui/bookmarks/bookmark_collection_view.mm:1328: 
The 2 functions below are learnt from recent_tabs_panel_controller.mm

https://codereview.chromium.org/2970693004/diff/1/ios/chrome/browser/ui/bookm...
ios/chrome/browser/ui/bookmarks/bookmark_collection_view.mm:1346: 
It seems we might need to take care of Sync Error below
by showing a sync error message?
might do it on another CL.

[Marti Wong, 2017-07-05 08:11:55]

Hi Ramya,

please hold on for the review.

it seems I should not use the synced_sessions_bridge class here directly from
ios/chrome/browser/ui/ntp/recent_tabs/

I should create a new synced_sessions_bridge class under ui/bookmarks/
Or just put those session observer stuff to bookmark_collection_view.

I am working on it now.  I will send you for review again after that.

Thanks~!

[Marti Wong, 2017-07-12 04:11:07]

The CQ bit was checked by martiw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-12 04:11:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marti Wong, 2017-07-12 04:12:03]

Description was changed from

==========
Show a loading spinner on bookmarks panel when syncing.

BUG=696893
==========

to

==========
No need review.  This is an experiment CL.
Show a loading spinner on bookmarks panel when syncing.

BUG=696893
==========

[Marti Wong, 2017-07-12 04:12:03]

martiw@chromium.org changed reviewers:
- ramyasharma@chromium.org

[commit-bot: I haz the power, 2017-07-12 05:25:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-12 05:25:53]

Dry run: This issue passed the CQ dry run.