Handle static fields in js_model/model_test

Handle static fields in js_model/model_test

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/e340ee517aac01260e68d6feaccf8abf08811f5b

[Johnni Winther, 2017-07-04 12:17:58]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-07-05 20:49:06]

lgtm, modulo some renaming :)

https://codereview.chromium.org/2970673004/diff/1/pkg/compiler/lib/src/kernel...
File pkg/compiler/lib/src/kernel/element_map_impl.dart (right):

https://codereview.chromium.org/2970673004/diff/1/pkg/compiler/lib/src/kernel...
pkg/compiler/lib/src/kernel/element_map_impl.dart:975: abstract class
KernelToElementMapForBuildingFromBaseMixin
I think I lost you somewhere after Map... 

Is there any name that describes why these functions are shared, or a split of
multiple mixins so we can name them more easily. 

Except for `forEachParameter`, it seems we could call this 
"ConstantFieldMapMixin" (since it is mostly about support for understainding
constant values of field initializers.)

Maybe we can move the foreachParameter to the base class?

[Johnni Winther, 2017-07-06 14:23:45]

Patchset #2 (id:20001) has been deleted

[Johnni Winther, 2017-07-06 14:23:51]

https://codereview.chromium.org/2970673004/diff/1/pkg/compiler/lib/src/kernel...
File pkg/compiler/lib/src/kernel/element_map_impl.dart (right):

https://codereview.chromium.org/2970673004/diff/1/pkg/compiler/lib/src/kernel...
pkg/compiler/lib/src/kernel/element_map_impl.dart:975: abstract class
KernelToElementMapForBuildingFromBaseMixin
On 2017/07/05 20:49:05, Siggi Cherem (dart-lang) wrote:
> I think I lost you somewhere after Map... 
> 
> Is there any name that describes why these functions are shared, or a split of
> multiple mixins so we can name them more easily. 
> 
> Except for `forEachParameter`, it seems we could call this 
> "ConstantFieldMapMixin" (since it is mostly about support for understainding
> constant values of field initializers.)
> 
> Maybe we can move the foreachParameter to the base class?
> 

`FromBase` was an attempt. It's shared between those that extend
KernelToElementMapBase, i.e. not KernelAstAdapter.

Added doc.

[Johnni Winther, 2017-07-06 14:31:05]

Description was changed from

==========
Handle static fields in js_model/model_test
==========

to

==========
Handle static fields in js_model/model_test

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e340ee517aac01260e68d6feaccf8abf08811f5b
==========

[Johnni Winther, 2017-07-06 14:31:06]

Committed patchset #2 (id:40001) manually as
e340ee517aac01260e68d6feaccf8abf08811f5b (presubmit successful).