Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1858)

Issue 297063002: Fix patch_orderfile.py. (Closed)

Created:
6 years, 7 months ago by Philippe
Modified:
6 years, 6 months ago
Reviewers:
pasko
CC:
chromium-reviews, Maria
Visibility:
Public.

Description

Fix patch_orderfile.py. GNU Gold was only partially respecting the provided order file mainly due to the lack of the '.text.*' trailing line. BUG=372323 R=pasko@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273808

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address Egor's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M tools/cygprofile/patch_orderfile.py View 1 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Philippe
6 years, 7 months ago (2014-05-23 16:49:43 UTC) #1
pasko
w00t! LGTM!
6 years, 7 months ago (2014-05-26 14:27:41 UTC) #2
pasko
https://codereview.chromium.org/297063002/diff/1/tools/cygprofile/patch_orderfile.py File tools/cygprofile/patch_orderfile.py (right): https://codereview.chromium.org/297063002/diff/1/tools/cygprofile/patch_orderfile.py#newcode110 tools/cygprofile/patch_orderfile.py:110: # if (count % 500 == 0): please remove ...
6 years, 7 months ago (2014-05-26 14:27:48 UTC) #3
Philippe
Thanks, Egor! https://codereview.chromium.org/297063002/diff/1/tools/cygprofile/patch_orderfile.py File tools/cygprofile/patch_orderfile.py (right): https://codereview.chromium.org/297063002/diff/1/tools/cygprofile/patch_orderfile.py#newcode110 tools/cygprofile/patch_orderfile.py:110: # if (count % 500 == 0): ...
6 years, 7 months ago (2014-05-26 14:37:21 UTC) #4
Philippe
+ Maria FYI
6 years, 7 months ago (2014-05-26 14:40:15 UTC) #5
Philippe
The CQ bit was checked by pliard@chromium.org
6 years, 6 months ago (2014-05-30 11:27:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pliard@chromium.org/297063002/20001
6 years, 6 months ago (2014-05-30 11:28:49 UTC) #7
Philippe
6 years, 6 months ago (2014-05-30 13:03:27 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 manually as r273808 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698