Remove both rietveld config and review_lgtm setting from cq config

Remove both rietveld config and review_lgtm setting from cq config

BUG=735039
R=agable@chromium.org, tandrii@chromium.org

Committed: https://github.com/dart-lang/sdk/commit/b6d67828b3c6b7b10ff5a2686c663326e4c25e57

[Bill Hesse, 2017-06-30 15:20:58]

whesse@google.com changed reviewers:
+ agable@chromium.org, kustermann@google.com, tandrii@google.com

[agable, 2017-06-30 17:19:26]

LGTM, but tandrii should review too in case I'm missing something.

Also, this shouldn't land until you're 100% ready to switch to gerrit -- this
will entirely disable your Rietveld CQ.

[Bill Hesse, 2017-06-30 17:23:17]

On 2017/06/30 17:19:26, agable wrote:
> LGTM, but tandrii should review too in case I'm missing something.
> 
> Also, this shouldn't land until you're 100% ready to switch to gerrit -- this
> will entirely disable your Rietveld CQ.

We have no CQ of any type now.  We only have  Rietveld CLs and landing on
github.  We are creating a CQ running against dart.googlecode.com, which is not
the source of truth, and master on github is only mirrored to github-master on
dart.googlesource.  So master branch on dart.googlesource is experimental, and
will be switched to the source of truth when everything is working correctly.

As long as it doesn't disable our Rietveld pushes to github.com, this is fine.

[agable, 2017-06-30 17:28:56]

On 2017/06/30 at 17:23:17, whesse wrote:
> On 2017/06/30 17:19:26, agable wrote:
> > LGTM, but tandrii should review too in case I'm missing something.
> > 
> > Also, this shouldn't land until you're 100% ready to switch to gerrit --
this
> > will entirely disable your Rietveld CQ.
> 
> We have no CQ of any type now.  We only have  Rietveld CLs and landing on
github.  We are creating a CQ running against dart.googlecode.com, which is not
the source of truth, and master on github is only mirrored to github-master on
dart.googlesource.  So master branch on dart.googlesource is experimental, and
will be switched to the source of truth when everything is working correctly.
> 
> As long as it doesn't disable our Rietveld pushes to github.com, this is fine.

I see, I thought you had a CQ committing to github on your behalf (like luci and
catapult do). But dart is currently 100% "git cl land" for submitting reviewed
changes? In that case, yeah, you can go ahead with this CL.

[tandrii(chromium), 2017-06-30 19:07:42]

tandrii@chromium.org changed reviewers:
+ tandrii@chromium.org

[tandrii(chromium), 2017-06-30 19:07:42]

lgtm

https://codereview.chromium.org/2970543002/diff/1/tools/infra/config/cq.cfg
File tools/infra/config/cq.cfg (right):

https://codereview.chromium.org/2970543002/diff/1/tools/infra/config/cq.cfg#n...
tools/infra/config/cq.cfg:10: dry_run_access_list: "dart-team"
nit: not for this CL, but it's be great if you used groups named according to
our typical naming scheme:

project-dart-committers
project-dart-tryjob-access

each of these can still include dart-team.

[Bill Hesse, 2017-07-03 20:24:31]

Description was changed from

==========
Remove both rietveld config and review_lgtm setting from cq config

BUG=735039
==========

to

==========
Remove both rietveld config and review_lgtm setting from cq config

BUG=735039
R=agable@chromium.org, tandrii@chromium.org

Committed:
https://github.com/dart-lang/sdk/commit/b6d67828b3c6b7b10ff5a2686c663326e4c25e57
==========

[Bill Hesse, 2017-07-03 20:24:32]

Committed patchset #2 (id:20001) manually as
b6d67828b3c6b7b10ff5a2686c663326e4c25e57 (presubmit successful).

[Bill Hesse, 2017-07-03 20:33:24]

On 2017/06/30 19:07:42, tandrii(chromium) SLOW wrote:
> lgtm
> 
> https://codereview.chromium.org/2970543002/diff/1/tools/infra/config/cq.cfg
> File tools/infra/config/cq.cfg (right):
> 
>
https://codereview.chromium.org/2970543002/diff/1/tools/infra/config/cq.cfg#n...
> tools/infra/config/cq.cfg:10: dry_run_access_list: "dart-team"
> nit: not for this CL, but it's be great if you used groups named according to
> our typical naming scheme:
> 
> project-dart-committers
> project-dart-tryjob-access
> 
> each of these can still include dart-team.

Added this change to CL, because dart-team is an mdb group, and
project-dart-committers is already created and importing it.

[tandrii(chromium), 2017-07-03 21:30:35]

lgtm