Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 2970443002: Disable expansion of VirtualTree and VirtualCollection items (Closed)

Created:
3 years, 5 months ago by cbernaschina
Modified:
3 years, 5 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Disable expansion of VirtualTree and VirtualCollection items VirtualTree and VirtualCollection must have fixed size children. Expandable Ref Elements are by default able to expand. Added flag to disable the expansion when required. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/a8450243eb1016e04628916d64e35f5ec0d00462

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -29 lines) Patch
M runtime/observatory/lib/src/elements/context_ref.dart View 5 chunks +24 lines, -17 lines 0 comments Download
M runtime/observatory/lib/src/elements/field_ref.dart View 3 chunks +4 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/heap_snapshot.dart View 2 chunks +6 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/helpers/any_ref.dart View 2 chunks +11 lines, -6 lines 0 comments Download
M runtime/observatory/lib/src/elements/instance_ref.dart View 4 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
cbernaschina
3 years, 5 months ago (2017-06-29 23:02:31 UTC) #3
rmacnak
lgtm
3 years, 5 months ago (2017-06-29 23:23:50 UTC) #4
cbernaschina
3 years, 5 months ago (2017-06-29 23:24:56 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a8450243eb1016e04628916d64e35f5ec0d00462 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698