Don't depend on visiting local functions.

pkg/analyzer/test/src/dart/analysis/search_test.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
 
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/standard_resolution_map.dart';
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/src/dart/analysis/driver.dart';
@@ skipping 457 matching lines @@
   }
 
   test_searchReferences_FunctionElement_local() async {
     await _resolveTestUnit('''
 main() {
   test() {}
   test();
   print(test);
 }
 ''');
-    FunctionElement element = _findElement('test');
+    FunctionElement element = findElementsByName(testUnit, 'test').single;
     Element main = _findElement('main');
     var expected = [
       _expectId(main, SearchResultKind.INVOCATION, 'test();'),
       _expectId(main, SearchResultKind.REFERENCE, 'test);')
     ];
     await _verifyReferences(element, expected);
   }
 
   test_searchReferences_ImportElement_noPrefix() async {
     await _resolveTestUnit('''
@@ skipping 256 matching lines @@
 main() {
   foo(p) {
     p = 1;
     p += 2;
     print(p);
     p();
   }
   foo(42);
 }
 ''');
-    ParameterElement element = _findElement('p');
-    Element fooElement = _findElement('foo');
+    Element main = _findElement('main');
+    FunctionElement foo = findElementsByName(testUnit, 'foo').single;
+    ParameterElement element = foo.parameters.single;
     var expected = [
-      _expectId(fooElement, SearchResultKind.WRITE, 'p = 1;'),
-      _expectId(fooElement, SearchResultKind.READ_WRITE, 'p += 2;'),
-      _expectId(fooElement, SearchResultKind.READ, 'p);'),
-      _expectId(fooElement, SearchResultKind.INVOCATION, 'p();')
+      _expectId(main, SearchResultKind.WRITE, 'p = 1;'),
+      _expectId(main, SearchResultKind.READ_WRITE, 'p += 2;'),
+      _expectId(main, SearchResultKind.READ, 'p);'),
+      _expectId(main, SearchResultKind.INVOCATION, 'p();')
     ];
     await _verifyReferences(element, expected);
   }
 
   test_searchReferences_ParameterElement_ofMethod() async {
     await _resolveTestUnit('''
 class C {
   foo(p) {
     p = 1;
     p += 2;
@@ skipping 244 matching lines @@
   }
 
   test_searchReferences_TypeParameterElement_ofLocalFunction() async {
     await _resolveTestUnit('''
 main() {
   void foo<T>(T a) {
     void bar(T b) {}
   }
 }
 ''');
-    TypeParameterElement element = _findElement('T');
-    Element a = _findElement('a');
-    Element b = _findElement('b');
+    Element main = _findElement('main');
+    FunctionElement foo = findElementsByName(testUnit, 'foo').single;
+    TypeParameterElement element = foo.typeParameters.single;
     var expected = [
-      _expectId(a, SearchResultKind.REFERENCE, 'T a'),
-      _expectId(b, SearchResultKind.REFERENCE, 'T b'),
+      _expectId(main, SearchResultKind.REFERENCE, 'T a'),
+      _expectId(main, SearchResultKind.REFERENCE, 'T b'),
     ];
     await _verifyReferences(element, expected);
   }
 
   test_searchReferences_TypeParameterElement_ofMethod() async {
     await _resolveTestUnit('''
 class A {
   foo<T>(T p) {}
 }
 ''');
     TypeParameterElement element = _findElement('T');
     Element p = _findElement('p');
     var expected = [
       _expectId(p, SearchResultKind.REFERENCE, 'T p'),
     ];
     await _verifyReferences(element, expected);
   }
 
   test_searchReferences_TypeParameterElement_ofTopLevelFunction() async {
     await _resolveTestUnit('''
 foo<T>(T a) {
   bar(T b) {}
 }
 ''');
+    FunctionElement foo = _findElement('foo');
     TypeParameterElement element = _findElement('T');
     Element a = _findElement('a');
-    Element b = _findElement('b');
     var expected = [
       _expectId(a, SearchResultKind.REFERENCE, 'T a'),
-      _expectId(b, SearchResultKind.REFERENCE, 'T b'),
+      _expectId(foo, SearchResultKind.REFERENCE, 'T b'),
     ];
     await _verifyReferences(element, expected);
   }
 
   test_searchSubtypes() async {
     await _resolveTestUnit('''
 class T {}
 class A extends T {} // A
 class B = Object with T; // B
 class C implements T {} // C
@@ skipping 193 matching lines @@
     List<SearchResult> results = await driver.search.references(element);
     _assertResults(results, expectedMatches);
     expect(results, hasLength(expectedMatches.length));
   }
 
   static void _assertResults(
       List<SearchResult> matches, List<ExpectedResult> expectedMatches) {
     expect(matches, unorderedEquals(expectedMatches));
   }
 }