Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 2970343002: [LayoutNG] Move decision if a inline node is empty to CollectInlines. (Closed)

Created:
3 years, 5 months ago by ikilpatrick
Modified:
3 years, 5 months ago
Reviewers:
ianjkilpatrick, kojii
CC:
atotic+reviews_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, cbiesinger, chromium-reviews, dgrogan+ng_chromium.org, eae+blinkwatch, glebl+reviews_chromium.org, jchaffraix+rendering, lchoi+reviews_chromium.org, leviw+renderwatch, ojan+watch_chromium.org, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Move decision if a inline node is empty to CollectInlines. This is to simplify bfc resolving "abort" code. Inside NGLineBreaker we should be able to always have a resolved BFC offset with this change. In a followup i'll move the unpositioned floats behaviour to a separate walk if needed. BUG=635619 Review-Url: https://codereview.chromium.org/2970343002 Cr-Commit-Position: refs/heads/master@{#485655} Committed: https://chromium.googlesource.com/chromium/src/+/8b362497f43bbd6e95e901f5418dde03f3dfaf17

Patch Set 1 #

Patch Set 2 : fix unittests. #

Total comments: 6

Patch Set 3 : rename. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -36 lines) Patch
M third_party/WebKit/Source/core/layout/ng/inline/ng_inline_items_builder.h View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/inline/ng_inline_items_builder.cc View 1 2 6 chunks +37 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.cc View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node_data.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker.cc View 6 chunks +5 lines, -34 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker_test.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 41 (25 generated)
ikilpatrick
This will avoid a whole bunch of messy WTF::Optional within NGLineBreaker, additionally this will simplify ...
3 years, 5 months ago (2017-07-06 22:37:19 UTC) #6
ikilpatrick
This will avoid a whole bunch of messy WTF::Optional within NGLineBreaker, additionally this will simplify ...
3 years, 5 months ago (2017-07-06 22:37:20 UTC) #7
kojii
I like this simplification very much, thank you for the great idea!! https://codereview.chromium.org/2970343002/diff/20001/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_items_builder.h File third_party/WebKit/Source/core/layout/ng/inline/ng_inline_items_builder.h ...
3 years, 5 months ago (2017-07-07 03:54:57 UTC) #10
ianjkilpatrick
https://codereview.chromium.org/2970343002/diff/20001/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_items_builder.h File third_party/WebKit/Source/core/layout/ng/inline/ng_inline_items_builder.h (right): https://codereview.chromium.org/2970343002/diff/20001/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_items_builder.h#newcode55 third_party/WebKit/Source/core/layout/ng/inline/ng_inline_items_builder.h:55: bool IsNonEmpty() const { return is_non_empty_; } On 2017/07/07 ...
3 years, 5 months ago (2017-07-07 17:49:54 UTC) #14
ikilpatrick
ptal.
3 years, 5 months ago (2017-07-10 16:04:27 UTC) #17
kojii
lgtm, great!
3 years, 5 months ago (2017-07-11 02:23:36 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2970343002/40001
3 years, 5 months ago (2017-07-11 02:24:37 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: linux_layout_tests_layout_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_tests_layout_ng/builds/695)
3 years, 5 months ago (2017-07-11 03:19:42 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2970343002/40001
3 years, 5 months ago (2017-07-11 14:21:02 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: linux_layout_tests_layout_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_tests_layout_ng/builds/710)
3 years, 5 months ago (2017-07-11 16:23:55 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2970343002/40001
3 years, 5 months ago (2017-07-11 16:24:26 UTC) #28
kojii
ng bot is very flaky today, I'm trying to fix but if it still fails, ...
3 years, 5 months ago (2017-07-11 16:45:01 UTC) #29
ikilpatrick
On 2017/07/11 16:45:01, kojii wrote: > ng bot is very flaky today, I'm trying to ...
3 years, 5 months ago (2017-07-11 16:45:55 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2970343002/40001
3 years, 5 months ago (2017-07-11 16:46:22 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2970343002/40001
3 years, 5 months ago (2017-07-11 16:46:48 UTC) #37
commit-bot: I haz the power
3 years, 5 months ago (2017-07-11 16:57:16 UTC) #41
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8b362497f43bbd6e95e901f5418d...

Powered by Google App Engine
This is Rietveld 408576698