DevTools: do not clear console when preserving log

third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 28 matching lines @@
     this._messages = [];
     /** @type {!Map<!SDK.RuntimeModel, !Map<number, !ConsoleModel.ConsoleMessage>>} */
     this._messageByExceptionId = new Map();
     this._warnings = 0;
     this._errors = 0;
 
     SDK.targetManager.observeTargets(this);
   }
 
   /**
+   * @param {!ConsoleModel.ConsoleMessage} message
+   * @return {boolean}
+   */
+  static canMessageClearConsole(message) {
+    if (Common.moduleSetting('preserveConsoleLog').get() ||

[luoe, 2017/07/06 22:16:00]

ConsoleModel is the only place that knows that preserveLog setting should
prevent console.clear().  Maybe _clearIfNecessary() should be merged with this,
and we make 'message' an optional parameter?

[pfeldman, 2017/07/12 21:17:28]

As you prefer.

+        message.source !== ConsoleModel.ConsoleMessage.MessageSource.ConsoleAPI ||
+        message.type !== ConsoleModel.ConsoleMessage.MessageType.Clear)
+      return false;
+    var runtimeModel = message.runtimeModel();
+    var executionContext = runtimeModel.executionContext(message.executionContextId);

[pfeldman, 2017/07/12 21:17:28]

when executionContext.isDefault === false, we should not clear console. this is
like iframe to use in this case...

[luoe, 2017/07/13 00:42:03]

Done.

+    var resourceTreeModel = runtimeModel.target().model(SDK.ResourceTreeModel);
+    var frame = resourceTreeModel && executionContext && executionContext.frameId &&

[pfeldman, 2017/07/12 21:17:28]

If there is no resourceTreeModel, we should allow clear.

[luoe, 2017/07/13 00:42:03]

Done.

+        resourceTreeModel.frameForId(executionContext.frameId);
+    return !!(frame && frame.isMainFrame());
+  }
+
+  /**
    * @override
    * @param {!SDK.Target} target
    */
   targetAdded(target) {
     var resourceTreeModel = target.model(SDK.ResourceTreeModel);
     if (!resourceTreeModel || resourceTreeModel.cachedResourcesLoaded()) {
       this._initTarget(target);
       return;
     }
 
@@ skipping 94 matching lines @@
     Host.userMetrics.actionTaken(Host.UserMetrics.Action.ConsoleEvaluated);
   }
 
   /**
    * @param {!ConsoleModel.ConsoleMessage} msg
    */
   addMessage(msg) {
     if (msg.source === ConsoleModel.ConsoleMessage.MessageSource.Worker && SDK.targetManager.targetById(msg.workerId))
       return;
 
-    if (msg.source === ConsoleModel.ConsoleMessage.MessageSource.ConsoleAPI &&
-        msg.type === ConsoleModel.ConsoleMessage.MessageType.Clear)
+    if (ConsoleModel.ConsoleModel.canMessageClearConsole(msg))
       this._clear();
 
     this._messages.push(msg);
     var runtimeModel = msg.runtimeModel();
     if (msg._exceptionId && runtimeModel) {
       var modelMap = this._messageByExceptionId.get(runtimeModel);
       if (!modelMap) {
         modelMap = new Map();
         this._messageByExceptionId.set(runtimeModel, modelMap);
       }
@@ skipping 473 matching lines @@
   Warning: 'warning',
   Error: 'error'
 };
 
 ConsoleModel.ConsoleModel._events = Symbol('ConsoleModel.ConsoleModel.events');
 
 /**
  * @type {!ConsoleModel.ConsoleModel}
  */
 ConsoleModel.consoleModel;