Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

Issue 2970313002: DevTools: do not clear console when preserving log (Closed)
Patch Set: Move conditions into one place Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 3 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
4 * Copyright (C) 2009 Joseph Pecoraro 4 * Copyright (C) 2009 Joseph Pecoraro
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 186 matching lines...) Expand 10 before | Expand all | Expand 10 after
197 _buildMessage() { 197 _buildMessage() {
198 var messageElement; 198 var messageElement;
199 var messageText = this._message.messageText; 199 var messageText = this._message.messageText;
200 if (this._message.source === ConsoleModel.ConsoleMessage.MessageSource.Conso leAPI) { 200 if (this._message.source === ConsoleModel.ConsoleMessage.MessageSource.Conso leAPI) {
201 switch (this._message.type) { 201 switch (this._message.type) {
202 case ConsoleModel.ConsoleMessage.MessageType.Trace: 202 case ConsoleModel.ConsoleMessage.MessageType.Trace:
203 messageElement = this._format(this._message.parameters || ['console.tr ace']); 203 messageElement = this._format(this._message.parameters || ['console.tr ace']);
204 break; 204 break;
205 case ConsoleModel.ConsoleMessage.MessageType.Clear: 205 case ConsoleModel.ConsoleMessage.MessageType.Clear:
206 messageElement = createElementWithClass('span', 'console-info'); 206 messageElement = createElementWithClass('span', 'console-info');
207 messageElement.textContent = Common.UIString('Console was cleared'); 207 messageElement.textContent = ConsoleModel.ConsoleModel.canMessageClear Console(this._message) ?
208 Common.UIString('Console was cleared') :
209 Common.UIString('console.clear() was prevented from non-main frame or \'Preserve log\'');
pfeldman 2017/07/12 21:17:28 This does not sounds like a consistent sentence to
luoe 2017/07/13 00:42:03 Done.
210 messageElement.title =
211 Common.UIString('Clear all messages with ' + UI.shortcutRegistry.s hortcutTitleForAction('console.clear'));
208 break; 212 break;
209 case ConsoleModel.ConsoleMessage.MessageType.Assert: 213 case ConsoleModel.ConsoleMessage.MessageType.Assert:
210 var args = [Common.UIString('Assertion failed:')]; 214 var args = [Common.UIString('Assertion failed:')];
211 if (this._message.parameters) 215 if (this._message.parameters)
212 args = args.concat(this._message.parameters); 216 args = args.concat(this._message.parameters);
213 messageElement = this._format(args); 217 messageElement = this._format(args);
214 break; 218 break;
215 case ConsoleModel.ConsoleMessage.MessageType.Dir: 219 case ConsoleModel.ConsoleMessage.MessageType.Dir:
216 var obj = this._message.parameters ? this._message.parameters[0] : und efined; 220 var obj = this._message.parameters ? this._message.parameters[0] : und efined;
217 var args = ['%O', obj]; 221 var args = ['%O', obj];
(...skipping 1117 matching lines...) Expand 10 before | Expand all | Expand 10 after
1335 } 1339 }
1336 return this._element; 1340 return this._element;
1337 } 1341 }
1338 }; 1342 };
1339 1343
1340 /** 1344 /**
1341 * @const 1345 * @const
1342 * @type {number} 1346 * @type {number}
1343 */ 1347 */
1344 Console.ConsoleViewMessage.MaxLengthForLinks = 40; 1348 Console.ConsoleViewMessage.MaxLengthForLinks = 40;
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698