Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 2970283002: add `reload` to `dart_library` (Closed)

Created:
3 years, 5 months ago by jakemac
Modified:
3 years, 5 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : undo accidental overwrites #

Patch Set 3 : fix up one more accidental overwrite #

Total comments: 4

Patch Set 4 : code review updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -11 lines) Patch
M pkg/dev_compiler/lib/js/legacy/dart_library.js View 1 2 3 7 chunks +72 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jakemac
3 years, 5 months ago (2017-07-06 18:25:25 UTC) #2
vsm
lgtm https://codereview.chromium.org/2970283002/diff/40001/pkg/dev_compiler/lib/js/legacy/dart_library.js File pkg/dev_compiler/lib/js/legacy/dart_library.js (right): https://codereview.chromium.org/2970283002/diff/40001/pkg/dev_compiler/lib/js/legacy/dart_library.js#newcode55 pkg/dev_compiler/lib/js/legacy/dart_library.js:55: let reverseDeps = new Map(); How about calling ...
3 years, 5 months ago (2017-07-06 19:47:28 UTC) #3
jakemac
https://codereview.chromium.org/2970283002/diff/40001/pkg/dev_compiler/lib/js/legacy/dart_library.js File pkg/dev_compiler/lib/js/legacy/dart_library.js (right): https://codereview.chromium.org/2970283002/diff/40001/pkg/dev_compiler/lib/js/legacy/dart_library.js#newcode55 pkg/dev_compiler/lib/js/legacy/dart_library.js:55: let reverseDeps = new Map(); On 2017/07/06 19:47:28, vsm ...
3 years, 5 months ago (2017-07-06 20:12:11 UTC) #4
vsm
lgtm
3 years, 5 months ago (2017-07-06 20:15:33 UTC) #5
jakemac
3 years, 5 months ago (2017-07-06 20:16:22 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
7c1e0bea36713e6c01d7a765feb8604e23163cda (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698