Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(918)

Unified Diff: pkg/front_end/lib/src/fasta/loader.dart

Issue 2970273004: Deprecate all diagnostics methods that use strings. (Closed)
Patch Set: Merged with 4df146dd9a465d63344330bf3e45524b927c92ec Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/front_end/lib/src/fasta/kernel/verifier.dart ('k') | pkg/front_end/lib/src/fasta/messages.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/front_end/lib/src/fasta/loader.dart
diff --git a/pkg/front_end/lib/src/fasta/loader.dart b/pkg/front_end/lib/src/fasta/loader.dart
index a069d12c4b29fb8ddd9555210d459b6ef70709b2..64f5b638bc66a63b2be493e4fd044b9590bc54b5 100644
--- a/pkg/front_end/lib/src/fasta/loader.dart
+++ b/pkg/front_end/lib/src/fasta/loader.dart
@@ -10,7 +10,8 @@ import 'dart:collection' show Queue;
import 'builder/builder.dart' show Builder, LibraryBuilder;
-import 'errors.dart' show InputError, firstSourceUri, printUnexpected;
+import 'deprecated_problems.dart'
+ show deprecated_InputError, firstSourceUri, deprecated_printUnexpected;
import 'target_implementation.dart' show TargetImplementation;
@@ -30,14 +31,14 @@ abstract class Loader<L> {
///
/// A handled error is an error that has been added to the generated AST
/// already, for example, as a throw expression.
- final List<InputError> handledErrors = <InputError>[];
+ final List<deprecated_InputError> handledErrors = <deprecated_InputError>[];
/// List of all unhandled compile-time errors seen so far by libraries loaded
/// by this loader.
///
/// An unhandled error is an error that hasn't been handled, see
/// [handledErrors].
- final List<InputError> unhandledErrors = <InputError>[];
+ final List<deprecated_InputError> unhandledErrors = <deprecated_InputError>[];
LibraryBuilder coreLibrary;
@@ -100,7 +101,7 @@ abstract class Loader<L> {
uri.scheme == "dart" &&
uri.path.startsWith("_") &&
accessor.uri.scheme != "dart") {
- accessor.addCompileTimeError(
+ accessor.deprecated_addCompileTimeError(
charOffset, "Can't access platform private library.");
}
return builder;
@@ -167,13 +168,14 @@ ${format(ms / libraryCount, 3, 12)} ms/compilation unit.""");
///
/// If [wasHandled] is true, this error is added to [handledErrors],
/// otherwise it is added to [unhandledErrors].
- void addCompileTimeError(Uri fileUri, int charOffset, Object message,
+ void deprecated_addCompileTimeError(
+ Uri fileUri, int charOffset, Object message,
{bool silent: false, bool wasHandled: false}) {
if (!silent) {
- printUnexpected(fileUri, charOffset, message);
+ deprecated_printUnexpected(fileUri, charOffset, message);
}
(wasHandled ? handledErrors : unhandledErrors)
- .add(new InputError(fileUri, charOffset, message));
+ .add(new deprecated_InputError(fileUri, charOffset, message));
}
Builder getAbstractClassInstantiationError() {
« no previous file with comments | « pkg/front_end/lib/src/fasta/kernel/verifier.dart ('k') | pkg/front_end/lib/src/fasta/messages.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698