Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart

Issue 2970273004: Deprecate all diagnostics methods that use strings. (Closed)
Patch Set: Merged with 4df146dd9a465d63344330bf3e45524b927c92ec Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart b/pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
index 40eca1aa818cf2a444dfae9ad3eeb0441d5990d9..41da6ee7667caf461c971672851608d446ce5b2d 100644
--- a/pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
@@ -30,7 +30,7 @@ import 'package:kernel/ast.dart'
import 'package:kernel/frontend/accessors.dart';
import 'package:kernel/type_environment.dart';
-import '../errors.dart' show internalError;
+import '../deprecated_problems.dart' show deprecated_internalProblem;
/// Computes the return type of a (possibly factory) constructor.
InterfaceType computeConstructorReturnType(Member constructor) {
@@ -537,7 +537,7 @@ class KernelDirectMethodInvocation extends DirectMethodInvocation
// DirectMethodInvocation can only occur as a result of a use of `super`,
// and `super` can't appear inside a field initializer. So this code should
// never be reached.
- internalError(
+ deprecated_internalProblem(
'Unexpected call to _collectDependencies for DirectMethodInvocation');
}
@@ -563,7 +563,7 @@ class KernelDirectPropertyGet extends DirectPropertyGet
// DirectPropertyGet can only occur as a result of a use of `super`, and
// `super` can't appear inside a field initializer. So this code should
// never be reached.
- internalError(
+ deprecated_internalProblem(
'Unexpected call to _collectDependencies for DirectPropertyGet');
}
@@ -1451,7 +1451,7 @@ class KernelProcedure extends Procedure implements KernelMember {
new InstrumentationValueForType(inferredType));
function.returnType = inferredType;
} else {
- internalError(
+ deprecated_internalProblem(
'setInferredType called on a procedure that is not an accessor');
}
}
@@ -2413,22 +2413,22 @@ class KernelYieldStatement extends YieldStatement implements KernelStatement {
class _UnfinishedCascade extends Expression {
accept(v) {
- return internalError("Internal error: Unsupported operation.");
+ return deprecated_internalProblem("Internal error: Unsupported operation.");
}
accept1(v, arg) {
- return internalError("Internal error: Unsupported operation.");
+ return deprecated_internalProblem("Internal error: Unsupported operation.");
}
getStaticType(types) {
- return internalError("Internal error: Unsupported operation.");
+ return deprecated_internalProblem("Internal error: Unsupported operation.");
}
transformChildren(v) {
- return internalError("Internal error: Unsupported operation.");
+ return deprecated_internalProblem("Internal error: Unsupported operation.");
}
visitChildren(v) {
- return internalError("Internal error: Unsupported operation.");
+ return deprecated_internalProblem("Internal error: Unsupported operation.");
}
}

Powered by Google App Engine
This is Rietveld 408576698