Deprecate all diagnostics methods that use strings.

pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart

Index: pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart b/pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart
index 81158aa7ca3a42eddb278e6e624632ae533e74b7..8882a962112c8edeb96ebbf70e2e27b89c1d64ee 100644
--- a/pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart
@@ -27,7 +27,7 @@ import 'package:kernel/ast.dart'
 
 import 'package:kernel/class_hierarchy.dart' show ClassHierarchy;
 
-import '../errors.dart' show internalError;
+import '../deprecated_problems.dart' show deprecated_internalProblem;
 
 import '../dill/dill_member_builder.dart' show DillMemberBuilder;
 
@@ -82,7 +82,7 @@ abstract class KernelClassBuilder
     for (KernelTypeBuilder builder in arguments) {
       DartType type = builder.build(library);
       if (type == null) {
-        internalError("Bad type: ${builder.runtimeType}");
+        deprecated_internalProblem("Bad type: ${builder.runtimeType}");
       }
       typeArguments.add(type);
     }
@@ -134,9 +134,9 @@ abstract class KernelClassBuilder
               String message = "Redirection constructor target not found: "
                   "${redirectionTarget.fullNameForErrors}";
               if (builder.isConst) {
-                addCompileTimeError(builder.charOffset, message);
+                deprecated_addCompileTimeError(builder.charOffset, message);
               } else {
-                addWarning(builder.charOffset, message);
+                deprecated_addWarning(builder.charOffset, message);
               }
               // CoreTypes aren't computed yet, and this is the outline
               // phase. So we can't and shouldn't create a method body.
@@ -188,7 +188,7 @@ abstract class KernelClassBuilder
   void checkOverride(
       Member declaredMember, Member interfaceMember, bool isSetter) {
     if (declaredMember is Constructor || interfaceMember is Constructor) {
-      internalError(
+      deprecated_internalProblem(
           "Constructor in override check.", fileUri, declaredMember.fileOffset);
     }
     if (declaredMember is Procedure && interfaceMember is Procedure) {
@@ -232,7 +232,7 @@ abstract class KernelClassBuilder
     FunctionNode interfaceFunction = interfaceMember.function;
     if (declaredFunction.typeParameters?.length !=
         interfaceFunction.typeParameters?.length) {
-      addWarning(
+      deprecated_addWarning(
           declaredMember.fileOffset,
           "Declared type variables of '$name::${declaredMember.name.name}' "
           "doesn't match those on overridden method "
@@ -243,7 +243,7 @@ abstract class KernelClassBuilder
             interfaceFunction.requiredParameterCount ||
         declaredFunction.positionalParameters.length <
             interfaceFunction.positionalParameters.length) {
-      addWarning(
+      deprecated_addWarning(
           declaredMember.fileOffset,
           "The method '$name::${declaredMember.name.name}' has fewer "
           "positional arguments than those of overridden method "
@@ -252,7 +252,7 @@ abstract class KernelClassBuilder
     }
     if (interfaceFunction.requiredParameterCount <
         declaredFunction.requiredParameterCount) {
-      addWarning(
+      deprecated_addWarning(
           declaredMember.fileOffset,
           "The method '$name::${declaredMember.name.name}' has more "
           "required arguments than those of overridden method "
@@ -265,7 +265,7 @@ abstract class KernelClassBuilder
     }
     if (declaredFunction.namedParameters.length <
         interfaceFunction.namedParameters.length) {
-      addWarning(
+      deprecated_addWarning(
           declaredMember.fileOffset,
           "The method '$name::${declaredMember.name.name}' has fewer named "
           "arguments than those of overridden method "
@@ -282,7 +282,7 @@ abstract class KernelClassBuilder
       while (declaredNamedParameters.current.name !=
           interfaceNamedParameters.current.name) {
         if (!declaredNamedParameters.moveNext()) {
-          addWarning(
+          deprecated_addWarning(
               declaredMember.fileOffset,
               "The method '$name::${declaredMember.name.name}' doesn't have "
               "the named parameter '${interfaceNamedParameters.current.name}' "