Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: pkg/front_end/lib/src/fasta/compiler_command_line.dart

Issue 2970273004: Deprecate all diagnostics methods that use strings. (Closed)
Patch Set: Merged with 4df146dd9a465d63344330bf3e45524b927c92ec Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/compiler_command_line.dart
diff --git a/pkg/front_end/lib/src/fasta/compiler_command_line.dart b/pkg/front_end/lib/src/fasta/compiler_command_line.dart
index 8fc042009bbf00c5a99962de759f5d6fc7815495..fca56efe5640f71627c07db506addc93d19eccbd 100644
--- a/pkg/front_end/lib/src/fasta/compiler_command_line.dart
+++ b/pkg/front_end/lib/src/fasta/compiler_command_line.dart
@@ -6,7 +6,7 @@ library fasta.compiler_command_line;
import 'dart:io' show exit;
-import 'command_line.dart' show CommandLine, argumentError;
+import 'command_line.dart' show CommandLine, deprecated_argumentError;
import 'compiler_context.dart' show CompilerContext;
@@ -54,26 +54,28 @@ class CompilerCommandLine extends CommandLine {
}
if (options.containsKey("-o") && options.containsKey("--output")) {
- return argumentError(usage, "Can't specify both '-o' and '--output'.");
+ return deprecated_argumentError(
+ usage, "Can't specify both '-o' and '--output'.");
}
if (options.containsKey("-t") && options.containsKey("--target")) {
- return argumentError(usage, "Can't specify both '-t' and '--target'.");
+ return deprecated_argumentError(
+ usage, "Can't specify both '-t' and '--target'.");
}
if (options.containsKey("--compile-sdk") &&
options.containsKey("--platform")) {
- return argumentError(
+ return deprecated_argumentError(
usage, "Can't specify both '--compile-sdk' and '--platform'.");
}
if (programName == "compile_platform" && arguments.length != 3) {
- return argumentError(usage, "Expected three arguments.");
+ return deprecated_argumentError(usage, "Expected three arguments.");
} else if (arguments.isEmpty) {
- return argumentError(usage, "No Dart file specified.");
+ return deprecated_argumentError(usage, "No Dart file specified.");
}
Target target =
getTarget(targetName, new TargetFlags(strongMode: strongMode));
if (target == null) {
- return argumentError(
+ return deprecated_argumentError(
usage,
"Target '${targetName}' not recognized. "
"Valid targets are:\n ${targets.keys.join("\n ")}");
« no previous file with comments | « pkg/front_end/lib/src/fasta/compile_platform.dart ('k') | pkg/front_end/lib/src/fasta/deprecated_problems.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698