Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: pkg/front_end/lib/src/fasta/fasta.dart

Issue 2970273004: Deprecate all diagnostics methods that use strings. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/fasta.dart
diff --git a/pkg/front_end/lib/src/fasta/fasta.dart b/pkg/front_end/lib/src/fasta/fasta.dart
index 865192b2aa6fed78a8eaa327703b6683a72d2e65..984c1fbc4cbfd4318f203e2fa014ad9a7164d9fe 100644
--- a/pkg/front_end/lib/src/fasta/fasta.dart
+++ b/pkg/front_end/lib/src/fasta/fasta.dart
@@ -24,7 +24,12 @@ import 'compiler_command_line.dart' show CompilerCommandLine;
import 'compiler_context.dart' show CompilerContext;
-import 'errors.dart' show InputError, formatUnexpected, inputError, reportCrash;
+import 'deprecated_problems.dart'
+ show
+ deprecated_InputError,
+ deprecated_formatUnexpected,
+ deprecated_inputError,
+ reportCrash;
import 'kernel/kernel_target.dart' show KernelTarget;
@@ -82,9 +87,9 @@ Future<KernelTarget> outline(List<String> arguments) async {
new CompileTask(c, new Ticker(isVerbose: c.options.verbose));
return await task.buildOutline(c.options.output);
});
- } on InputError catch (e) {
+ } on deprecated_InputError catch (e) {
exitCode = 1;
- print(e.format());
+ print(e.deprecated_format());
return null;
}
}
@@ -100,9 +105,9 @@ Future<Uri> compile(List<String> arguments) async {
new CompileTask(c, new Ticker(isVerbose: c.options.verbose));
return await task.compile();
});
- } on InputError catch (e) {
+ } on deprecated_InputError catch (e) {
exitCode = 1;
- print(e.format());
+ print(e.deprecated_format());
return null;
}
}
@@ -143,7 +148,7 @@ class CompileTask {
if (path.endsWith(".dart")) {
kernelTarget.read(uri);
} else {
- inputError(uri, -1, "Unexpected input: $uri");
+ deprecated_inputError(uri, -1, "Unexpected input: $uri");
}
await dillTarget.buildOutlines();
var outline = await kernelTarget.buildOutlines();
@@ -185,11 +190,11 @@ Future<CompilationResult> parseScriptInFileSystem(Uri fileName,
try {
if (!await fileSystem.entityForUri(fileName).exists()) {
return new CompilationResult.error(
- formatUnexpected(fileName, -1, "No such file."));
+ deprecated_formatUnexpected(fileName, -1, "No such file."));
}
if (!await new Directory.fromUri(patchedSdk).exists()) {
- return new CompilationResult.error(
- formatUnexpected(patchedSdk, -1, "Patched sdk directory not found."));
+ return new CompilationResult.error(deprecated_formatUnexpected(
+ patchedSdk, -1, "Patched sdk directory not found."));
}
Program program;
@@ -209,8 +214,8 @@ Future<CompilationResult> parseScriptInFileSystem(Uri fileName,
if (kernelTarget.errors.isNotEmpty) {
return new CompilationResult.errors(kernelTarget.errors);
}
- } on InputError catch (e) {
- return new CompilationResult.error(e.format());
+ } on deprecated_InputError catch (e) {
+ return new CompilationResult.error(e.deprecated_format());
}
if (program.mainMethod == null) {

Powered by Google App Engine
This is Rietveld 408576698