Deprecate all diagnostics methods that use strings.

pkg/front_end/lib/src/fasta/kernel/kernel_target.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library fasta.kernel_target;
 
 import 'dart:async' show Future;
 
 import 'dart:io' show File;
 
@@ skipping 36 matching lines @@
 import '../source/source_loader.dart' show SourceLoader;
 
 import '../source/source_class_builder.dart' show SourceClassBuilder;
 
 import '../target_implementation.dart' show TargetImplementation;
 
 import '../translate_uri.dart' show TranslateUri;
 
 import '../dill/dill_target.dart' show DillTarget;
 
-import '../errors.dart'
-    show InputError, internalError, reportCrash, resetCrashReporting;
+import '../deprecated_problems.dart'
+    show
+        deprecated_InputError,
+        deprecated_internalProblem,
+        reportCrash,
+        resetCrashReporting;
 
 import '../util/relativize.dart' show relativizeUri;
 
 import '../compiler_context.dart' show CompilerContext;
 
 import 'kernel_builder.dart'
     show
         Builder,
         ClassBuilder,
         InvalidTypeBuilder,
@@ skipping 37 matching lines @@
   KernelTarget(
       this.fileSystem, DillTarget dillTarget, TranslateUri uriTranslator,
       [Map<String, Source> uriToSource])
       : dillTarget = dillTarget,
         uriToSource = uriToSource ?? CompilerContext.current.uriToSource,
         super(dillTarget.ticker, uriTranslator, dillTarget.backendTarget) {
     resetCrashReporting();
     loader = createLoader();
   }
 
-  void addError(file, int charOffset, String message) {
+  void deprecated_addError(file, int charOffset, String message) {
     Uri uri = file is String ? Uri.parse(file) : file;
-    InputError error = new InputError(uri, charOffset, message);
-    String formatterMessage = error.format();
+    deprecated_InputError error =
+        new deprecated_InputError(uri, charOffset, message);
+    String formatterMessage = error.deprecated_format();
     print(formatterMessage);
     errors.add(formatterMessage);
   }
 
   SourceLoader<Library> createLoader() =>
       new SourceLoader<Library>(fileSystem, this);
 
   void addSourceInformation(
       Uri uri, List<int> lineStarts, List<int> sourceCode) {
     String fileUri = relativizeUri(uri);
@@ skipping 12 matching lines @@
       }
     }
     return new KernelLibraryBuilder(uri, fileUri, loader, isPatch);
   }
 
   void forEachDirectSupertype(ClassBuilder cls, void f(NamedTypeBuilder type)) {
     TypeBuilder supertype = cls.supertype;
     if (supertype is NamedTypeBuilder) {
       f(supertype);
     } else if (supertype != null) {
-      internalError("Unhandled: ${supertype.runtimeType}");
+      deprecated_internalProblem("Unhandled: ${supertype.runtimeType}");
     }
     if (cls.interfaces != null) {
       for (NamedTypeBuilder t in cls.interfaces) {
         f(t);
       }
     }
     if (cls.library.loader == loader &&
         // TODO(ahe): Implement DillClassBuilder.mixedInType and remove the
         // above check.
         cls.mixedInType != null) {
@@ skipping 44 matching lines @@
     cls.implementedTypes.clear();
     cls.supertype = null;
     cls.mixedInType = null;
     builder.supertype = new KernelNamedTypeBuilder("Object", null,
         builder.charOffset, builder.fileUri ?? Uri.parse(cls.fileUri))
       ..builder = objectClassBuilder;
     builder.interfaces = null;
     builder.mixedInType = null;
   }
 
-  void handleInputError(InputError error,
+  void handleInputError(deprecated_InputError error,
       {bool isFullProgram, bool trimDependencies: false}) {
     if (error != null) {
-      String message = error.format();
+      String message = error.deprecated_format();
       print(message);
       errors.add(message);
     }
     program = erroneousProgram(isFullProgram);
   }
 
   @override
   Future<Program> buildOutlines({CanonicalName nameRoot}) async {
     if (loader.first == null) return null;
     try {
@@ skipping 11 matching lines @@
       installDefaultSupertypes();
       installDefaultConstructors(sourceClasses);
       loader.resolveConstructors();
       loader.finishTypeVariables(objectClassBuilder);
       program =
           link(new List<Library>.from(loader.libraries), nameRoot: nameRoot);
       loader.computeHierarchy(program);
       loader.checkOverrides(sourceClasses);
       loader.prepareInitializerInference();
       loader.performInitializerInference();
-    } on InputError catch (e) {
+    } on deprecated_InputError catch (e) {
       handleInputError(e, isFullProgram: false);
     } catch (e, s) {
       return reportCrash(e, s, loader?.currentUriForCrashReporting);
     }
     return program;
   }
 
   /// Build the kernel representation of the program loaded by this target. The
   /// program will contain full bodies for the code loaded from sources, and
   /// only references to the code loaded by the [DillTarget], which may or may
@@ skipping 23 matching lines @@
       finishAllConstructors();
       loader.finishNativeMethods();
       runBuildTransformations();
 
       if (verify) this.verify();
       if (errors.isNotEmpty) {
         handleInputError(null,
             isFullProgram: true, trimDependencies: trimDependencies);
       }
       handleRecoverableErrors(loader.unhandledErrors);
-    } on InputError catch (e) {
+    } on deprecated_InputError catch (e) {
       handleInputError(e,
           isFullProgram: true, trimDependencies: trimDependencies);
     } catch (e, s) {
       return reportCrash(e, s, loader?.currentUriForCrashReporting);
     }
     if (trimDependencies) trimDependenciesInProgram();
     return program;
   }
 
   Future writeDepsFile(Uri output, Uri depsFile,
@@ skipping 40 matching lines @@
     ticker.logMs("Wrote deps file");
   }
 
   /// Adds a synthetic field named `#errors` to the main library that contains
   /// [recoverableErrors] formatted.
   ///
   /// If [recoverableErrors] is empty, this method does nothing.
   ///
   /// If there's no main library, this method uses [erroneousProgram] to
   /// replace [program].
-  void handleRecoverableErrors(List<InputError> recoverableErrors) {
+  void handleRecoverableErrors(List<deprecated_InputError> recoverableErrors) {
     if (recoverableErrors.isEmpty) return;
     KernelLibraryBuilder mainLibrary = loader.first;
     if (mainLibrary == null) {
       program = erroneousProgram(true);
       return;
     }
     List<Expression> expressions = <Expression>[];
-    for (InputError error in recoverableErrors) {
-      String message = error.format();
+    for (deprecated_InputError error in recoverableErrors) {
+      String message = error.deprecated_format();
       errors.add(message);
       expressions.add(new StringLiteral(message));
     }
     mainLibrary.library.addMember(new Field(new Name("#errors"),
         initializer: new ListLiteral(expressions, isConst: true),
         isConst: true));
   }
 
   Program erroneousProgram(bool isFullProgram) {
     Uri uri = loader.first?.uri ?? Uri.parse("error:error");
@@ skipping 93 matching lines @@
       /// >that is accessible to LM , C has an implicitly declared constructor
       /// >named q'i = [C/S]qi of the form q'i(ai1,...,aiki) :
       /// >super(ai1,...,aiki);.
       TypeDeclarationBuilder supertype = builder;
       while (supertype.isMixinApplication) {
         SourceClassBuilder named = supertype;
         TypeBuilder type = named.supertype;
         if (type is NamedTypeBuilder) {
           supertype = type.builder;
         } else {
-          internalError("Unhandled: ${type.runtimeType}");
+          deprecated_internalProblem("Unhandled: ${type.runtimeType}");
         }
       }
       if (supertype is KernelClassBuilder) {
         Map<TypeParameter, DartType> substitutionMap =
             computeKernelSubstitutionMap(
                 builder.getSubstitutionMap(supertype, builder.fileUri,
                     builder.charOffset, dynamicType),
                 builder.parent);
         if (supertype.cls.constructors.isEmpty) {
           builder.addSyntheticConstructor(makeDefaultConstructor());
         } else {
           for (Constructor constructor in supertype.cls.constructors) {
             builder.addSyntheticConstructor(makeMixinApplicationConstructor(
                 builder.cls.mixin, constructor, substitutionMap));
           }
         }
       } else if (supertype is InvalidTypeBuilder) {
         builder.addSyntheticConstructor(makeDefaultConstructor());
       } else {
-        internalError("Unhandled: ${supertype.runtimeType}");
+        deprecated_internalProblem("Unhandled: ${supertype.runtimeType}");
       }
     } else {
       /// >Iff no constructor is specified for a class C, it implicitly has a
       /// >default constructor C() : super() {}, unless C is class Object.
       // The superinitializer is installed below in [finishConstructors].
       builder.addSyntheticConstructor(makeDefaultConstructor());
     }
   }
 
   Map<TypeParameter, DartType> computeKernelSubstitutionMap(
@@ skipping 85 matching lines @@
       MemberBuilder constructorBuilder = member;
       Constructor constructor = constructorBuilder.target;
       if (!constructorBuilder.isRedirectingGenerativeConstructor) {
         /// >If no superinitializer is provided, an implicit superinitializer
         /// >of the form super() is added at the end of k’s initializer list,
         /// >unless the enclosing class is class Object.
         if (constructor.initializers.isEmpty) {
           superTarget ??= defaultSuperConstructor(cls);
           Initializer initializer;
           if (superTarget == null) {
-            addError(
+            deprecated_addError(
                 constructor.enclosingClass.fileUri,
                 constructor.fileOffset,
                 "${cls.superclass.name} has no constructor that takes no"
                 " arguments.");
             initializer = new InvalidInitializer();
           } else {
             initializer =
                 new SuperInitializer(superTarget, new Arguments.empty());
           }
           constructor.initializers.add(initializer);
           initializer.parent = constructor;
         }
         if (constructor.function.body == null) {
           /// >If a generative constructor c is not a redirecting constructor
           /// >and no body is provided, then c implicitly has an empty body {}.
           /// We use an empty statement instead.
           constructor.function.body = new EmptyStatement();
           constructor.function.body.parent = constructor.function;
         }
         List<FieldInitializer> myFieldInitializers = <FieldInitializer>[];
         for (Initializer initializer in constructor.initializers) {
           if (initializer is FieldInitializer) {
             myFieldInitializers.add(initializer);
           }
         }
         fieldInitializers[constructor] = myFieldInitializers;
         if (constructor.isConst && nonFinalFields.isNotEmpty) {
-          addError(constructor.enclosingClass.fileUri, constructor.fileOffset,
+          deprecated_addError(
+              constructor.enclosingClass.fileUri,
+              constructor.fileOffset,
               "Constructor is marked 'const' so all fields must be final.");
           for (Field field in nonFinalFields) {
-            addError(constructor.enclosingClass.fileUri, field.fileOffset,
+            deprecated_addError(
+                constructor.enclosingClass.fileUri,
+                field.fileOffset,
                 "Field isn't final, but constructor is 'const'.");
           }
           nonFinalFields.clear();
         }
       }
     });
     Set<Field> initializedFields;
     fieldInitializers.forEach(
         (Constructor constructor, List<FieldInitializer> initializers) {
       Iterable<Field> fields = initializers.map((i) => i.field);
@@ skipping 80 matching lines @@
   }
   for (Constructor constructor in superclass.constructors) {
     if (constructor.name.name.isEmpty) {
       return constructor.function.requiredParameterCount == 0
           ? constructor
           : null;
     }
   }
   return null;
 }