Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5101)

Unified Diff: chrome/browser/media/router/mojo/media_router_mojo_impl.h

Issue 2970273002: [Media Router] Remove the extension ID getter from MRMojoImpl (Closed)
Patch Set: . Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/router/mojo/media_router_mojo_impl.h
diff --git a/chrome/browser/media/router/mojo/media_router_mojo_impl.h b/chrome/browser/media/router/mojo/media_router_mojo_impl.h
index b2ccaf563fe2ecf90dc759ce4689bc70e698345a..3a53511775508579493261267063e2e4dab6b622 100644
--- a/chrome/browser/media/router/mojo/media_router_mojo_impl.h
+++ b/chrome/browser/media/router/mojo/media_router_mojo_impl.h
@@ -114,9 +114,6 @@ class MediaRouterMojoImpl : public MediaRouterBase,
scoped_refptr<MediaRouteController> GetRouteController(
const MediaRoute::Id& route_id) override;
- // TODO(crbug.com/597778): Remove this getter.
imcheng 2017/07/07 21:15:43 Seems this patch will fix crbug.com/727993 as well
takumif 2017/07/07 21:58:58 Done.
- const std::string& media_route_provider_extension_id() const;
-
void set_instance_id_for_test(const std::string& instance_id) {
instance_id_ = instance_id;
}
@@ -217,7 +214,7 @@ class MediaRouterMojoImpl : public MediaRouterBase,
// Binds |this| to a Mojo interface request, so that clients can acquire a
// handle to a MediaRouterMojoImpl instance via the Mojo service connector.
- // Stores the ID of |extension| in |media_route_provider_extension_id_|.
+ // Passes the extension's ID to the event page request manager.
void BindToMojoRequest(
mojo::InterfaceRequest<mojom::MediaRouter> request,
const extensions::Extension& extension);

Powered by Google App Engine
This is Rietveld 408576698