Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 297023002: Cleanup: Convert chrome_browser_main_linux.cc to use the blocking thread pool. (Closed)

Created:
6 years, 7 months ago by Lei Zhang
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Cleanup: Convert chrome_browser_main_linux.cc to use the blocking thread pool. Also remove cruft and simplify code. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272728

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -27 lines) Patch
M chrome/browser/chrome_browser_main_linux.cc View 2 chunks +6 lines, -23 lines 0 comments Download
M chrome/browser/sxs_linux.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sxs_linux.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
Lei Zhang
6 years, 7 months ago (2014-05-23 07:54:33 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 7 months ago (2014-05-23 07:59:20 UTC) #2
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 7 months ago (2014-05-23 08:02:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/297023002/1
6 years, 7 months ago (2014-05-23 08:03:12 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-23 11:15:48 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-23 11:33:25 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/builds/34579)
6 years, 7 months ago (2014-05-23 11:33:25 UTC) #7
Lei Zhang
On 2014/05/23 11:33:25, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 7 months ago (2014-05-23 22:03:11 UTC) #8
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 7 months ago (2014-05-23 22:03:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/297023002/20001
6 years, 7 months ago (2014-05-23 22:04:11 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-24 02:50:52 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-24 05:10:00 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/builds/32373)
6 years, 7 months ago (2014-05-24 05:10:00 UTC) #13
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 7 months ago (2014-05-24 05:55:36 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/297023002/20001
6 years, 7 months ago (2014-05-24 05:55:45 UTC) #15
commit-bot: I haz the power
6 years, 7 months ago (2014-05-24 12:57:12 UTC) #16
Message was sent while issue was closed.
Change committed as 272728

Powered by Google App Engine
This is Rietveld 408576698