Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Unified Diff: net/http/http_cache.h

Issue 2970133002: DoomPartialEntry should not attempt to doom an already doomed entry. (Closed)
Patch Set: Test and test framework changes added. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/http/http_cache_transaction.cc » ('j') | net/http/http_cache_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_cache.h
diff --git a/net/http/http_cache.h b/net/http/http_cache.h
index e420c7244204874988b4908149bf51a2bd8697a3..28ce090d4189c7780d07cbb50d914f4b30beec1c 100644
--- a/net/http/http_cache.h
+++ b/net/http/http_cache.h
@@ -341,7 +341,9 @@ class NET_EXPORT HttpCache : public HttpTransactionFactory {
// Dooms the entry selected by |key|. |trans| will be notified via its IO
// callback if this method returns ERR_IO_PENDING. The entry can be
- // currently in use or not.
+ // currently in use or not. If entry is in use and the invoking transaction
+ // is associated with this entry and this entry is already doomed, this API
+ // should not be invoked.
int DoomEntry(const std::string& key, Transaction* trans);
// Dooms the entry selected by |key|. |trans| will be notified via its IO
« no previous file with comments | « no previous file | net/http/http_cache_transaction.cc » ('j') | net/http/http_cache_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698