Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 297010: Pull in googleurl @ r=120 to fix the query part encoding handling (the patch ... (Closed)

Created:
11 years, 2 months ago by jungshik at Google
Modified:
9 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Pull in googleurl @ r=120 to fix the query part encoding handling (the patch by Roland Steiner). What Roland wrote at http://codereview.chromium.org/243028/show Encoding of the query part of an URL was inconsistent: If it was part of a larger relative URL, it would get encoded. However, if the query part was stand-alone, then it would not be encoded. As indicated by the original layout test referenced in the bug (see below), this patch changes the code so that the query part is encoded in both cases. Note, however, that with this patch the layout test will NOT yet fully pass, since it also handles the fragment part differently. As the different handling of the fragment part seems to be quite on purpose, I have not modified the behavior - see the discussion at http://code.google.com/p/chromium/issues/detail?id=20507 . BUG=8912, 20507 TBR=brettw Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29470

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
jungshik at Google
11 years, 2 months ago (2009-10-19 21:49:07 UTC) #1
brettw
11 years, 2 months ago (2009-10-19 23:33:17 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698