Emit object replacement char to IME

Source/core/editing/TextIterator.cpp

 /*
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2005 Alexey Proskuryakov.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 247 matching lines @@
     , m_hasEmitted(false)
     , m_emitsCharactersBetweenAllVisiblePositions(behavior & TextIteratorEmitsCharactersBetweenAllVisiblePositions)
     , m_entersTextControls(behavior & TextIteratorEntersTextControls)
     , m_emitsOriginalText(behavior & TextIteratorEmitsOriginalText)
     , m_handledFirstLetter(false)
     , m_ignoresStyleVisibility(behavior & TextIteratorIgnoresStyleVisibility)
     , m_stopsOnFormControls(behavior & TextIteratorStopsOnFormControls)
     , m_shouldStop(false)
     , m_emitsImageAltText(behavior & TextIteratorEmitsImageAltText)
     , m_entersAuthorShadowRoots(behavior & TextIteratorEntersAuthorShadowRoots)
+    , m_emitsReplacementChar(behavior & TextIteratorEmitsReplacementChar)
 {
     if (range)
         initialize(range->startPosition(), range->endPosition());
 }
 
 TextIterator::TextIterator(const Position& start, const Position& end, TextIteratorBehaviorFlags behavior)
     : m_startContainer(0)
     , m_startOffset(0)
     , m_endContainer(0)
     , m_endOffset(0)
@@ skipping 10 matching lines @@
     , m_hasEmitted(false)
     , m_emitsCharactersBetweenAllVisiblePositions(behavior & TextIteratorEmitsCharactersBetweenAllVisiblePositions)
     , m_entersTextControls(behavior & TextIteratorEntersTextControls)
     , m_emitsOriginalText(behavior & TextIteratorEmitsOriginalText)
     , m_handledFirstLetter(false)
     , m_ignoresStyleVisibility(behavior & TextIteratorIgnoresStyleVisibility)
     , m_stopsOnFormControls(behavior & TextIteratorStopsOnFormControls)
     , m_shouldStop(false)
     , m_emitsImageAltText(behavior & TextIteratorEmitsImageAltText)
     , m_entersAuthorShadowRoots(behavior & TextIteratorEntersAuthorShadowRoots)
+    , m_emitsReplacementChar(behavior & TextIteratorEmitsReplacementChar)
 {
     initialize(start, end);
 }
 
 void TextIterator::initialize(const Position& start, const Position& end)
 {
     ASSERT(comparePositions(start, end) <= 0);
 
     // Get and validate |start| and |end|.
     Node* startContainer = start.containerNode();
@@ skipping 467 matching lines @@
 
 bool TextIterator::handleReplacedElement()
 {
     if (m_fullyClippedStack.top())
         return false;
 
     RenderObject* renderer = m_node->renderer();
     if (renderer->style()->visibility() != VISIBLE && !m_ignoresStyleVisibility)
         return false;
 
+    if (m_entersTextControls && renderer->isTextControl()) {
+        // The shadow tree should be already visited.
+        return true;
+    }
+
+    if (m_emitsReplacementChar) {
+        emitCharacter(objectReplacementCharacter, m_node->parentNode(), m_node, 0, 1);
+        return true;
+    }
+
     if (m_lastTextNodeEndedWithCollapsedSpace) {
         emitCharacter(' ', m_lastTextNode->parentNode(), m_lastTextNode, 1, 1);
         return false;
     }
 
-    if (m_entersTextControls && renderer->isTextControl()) {

[leviw_travelin_and_unemployed, 2014/05/27 23:33:45]

Why are you pulling this up above the m_lastTextNodeEndedWithCollapsedSpace? Is
that necessary?

[guohui, 2014/05/28 01:17:06]

actually it was not clear to me why this was not up above in the first place.
The comment seems to suggest that we should emit nothing for a shadow control,
why do we make an exception when the last text node ends with a collapsed space?

[Yuta Kitamura, 2014/05/28 07:36:07]

Text control case does seem like a bug, but I think we need to emit a space
before a replacement character, no?

[guohui, 2014/05/28 13:19:12]

reverted, we'd better fix the text control case in a separate CL.

As for the replaced element, do you mean that we should emit an empty space
followed by 0xFFFC when m_lastTextNodeEndedWithCollapsedSpace == true?

[guohui, 2014/05/28 13:32:39]

Correction:

when m_lastTextNodeEndedWithCollapsedSpace == true?
->
when m_lastTextNodeEndedWithCollapsedSpace && m_emitsObjectReplacementCharacter?

-        // The shadow tree should be already visited.
-        return true;
-    }
-
     m_hasEmitted = true;
 
     if (m_emitsCharactersBetweenAllVisiblePositions) {
         // We want replaced elements to behave like punctuation for boundary
         // finding, and to simply take up space for the selection preservation
         // code in moveParagraphs, so we use a comma.
         emitCharacter(',', m_node->parentNode(), m_node, 0, 1);
         return true;
     }
 
@@ skipping 1390 matching lines @@
             resultEnd = collapseTo;
             return;
         }
     }
 
     CharacterIterator computeRangeIterator(inputStart, inputEnd, iteratorFlagsForFindPlainText);
     calculateCharacterSubrange(computeRangeIterator, matchStart, matchLength, resultStart, resultEnd);
 }
 
 }