Implement URLRequestDataJob

net/base/net_util.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/net_util.h"
 
 #include <algorithm>
 #include <map>
 #include <unicode/ucnv.h>
 #include <unicode/uidna.h>
@@ skipping 1018 matching lines @@
 std::wstring StripWWW(const std::wstring& text) {
   const std::wstring www(L"www.");
   return (text.compare(0, www.length(), www) == 0) ?
       text.substr(www.length()) : text;
 }
 
 std::wstring GetSuggestedFilename(const GURL& url,
                                   const std::string& content_disposition,
                                   const std::string& referrer_charset,
                                   const std::wstring& default_name) {
+  // TODO(rolandsteiner): as pointed out by darin in the code review, this is
+  // hardly ideal. "download" should be translated, or another solution found.
+  // (cf. http://code.google.com/p/chromium/issues/detail?id=25289)
+  const wchar_t kFinalFallbackName[] = L"download";
+
+  // about: and data: URLs don't have file names, but esp. data: URLs may
+  // contain parts that look like ones (i.e., contain a slash).
+  // Therefore we don't attempt to divine a file name out of them.
+  if (url.SchemeIs("about") || url.SchemeIs("data"))
+    return default_name.empty() ? std::wstring(kFinalFallbackName)
+                                : default_name;
+
   std::wstring filename = GetFileNameFromCD(content_disposition,
                                             referrer_charset);
   if (!filename.empty()) {
     // Remove any path information the server may have sent, take the name
     // only.
     filename = file_util::GetFilenameFromPath(filename);
     // Next, remove "." from the beginning and end of the file name to avoid
     // tricks with hidden files, "..", and "."
     TrimString(filename, L".", &filename);
   }
   if (filename.empty()) {
     if (url.is_valid()) {
       filename = UnescapeAndDecodeUTF8URLComponent(
           url.ExtractFileName(),
           UnescapeRule::SPACES | UnescapeRule::URL_SPECIAL_CHARS);
     }
   }
 
   // Trim '.' once more.
   TrimString(filename, L".", &filename);
   // If there's no filename or it gets trimed to be empty, use
   // the URL hostname or default_name
   if (filename.empty()) {
     if (!default_name.empty()) {
       filename = default_name;
     } else if (url.is_valid()) {
       // Some schemes (e.g. file) do not have a hostname. Even though it's
       // not likely to reach here, let's hardcode the last fallback name.
       // TODO(jungshik) : Decode a 'punycoded' IDN hostname. (bug 1264451)
-      filename = url.host().empty() ? L"download" : UTF8ToWide(url.host());
+      filename = url.host().empty() ? std::wstring(kFinalFallbackName)
+                                    : UTF8ToWide(url.host());
     } else {
       NOTREACHED();
     }
   }
 
   file_util::ReplaceIllegalCharacters(&filename, '-');
   return filename;
 }
 
 bool IsPortAllowedByDefault(int port) {
@@ skipping 335 matching lines @@
       if (length > 0)
         ports.insert(StringToInt(WideToASCII(
             allowed_ports.substr(last, length))));
       last = i + 1;
     }
   }
   explicitly_allowed_ports = ports;
 }
 
 }  // namespace net