[Payment Request] Displays appropriate footer if first transaction completed

ios/chrome/browser/payments/test_payment_request.h

Index: ios/chrome/browser/payments/test_payment_request.h
diff --git a/ios/chrome/browser/payments/test_payment_request.h b/ios/chrome/browser/payments/test_payment_request.h
index 5435eb9d71ecaec3f386823956298f1183fe4597..6d0415f7082e066b778b2b3cfedc6f8f88c421b4 100644
--- a/ios/chrome/browser/payments/test_payment_request.h
+++ b/ios/chrome/browser/payments/test_payment_request.h
@@ -26,6 +26,8 @@ class PaymentRequest;
 class PaymentShippingOption;
 }  // namespace web
 
+class PrefService;
+
 // PaymentRequest for use in tests.
 class TestPaymentRequest : public PaymentRequest {
  public:
@@ -39,9 +41,18 @@ class TestPaymentRequest : public PaymentRequest {
                        personal_data_manager,
                        payment_request_ui_delegate),
         region_data_loader_(nullptr),

[macourteau, 2017/07/05 14:10:36]

optional nit: I find it clearer when trivial default values are set where these
instance variables are declared:

  autofill::RegionDataLoader* region_data_loader_ = nullptr;
  // ...

[Moe, 2017/07/05 16:01:46]

Ack. However I think it's clearer if all member variable initialization, whether
initialization to a constructor argument or to a default trivial or non-trivial
value is done in one place, which is the constructor initializer list and/or its
body.  

+        pref_service_(nullptr),
         profile_comparator_(nullptr) {}
 
   TestPaymentRequest(const web::PaymentRequest& web_payment_request,
+                     ios::ChromeBrowserState* browser_state,
+                     autofill::PersonalDataManager* personal_data_manager)
+      : TestPaymentRequest(web_payment_request,
+                           browser_state,
+                           personal_data_manager,
+                           nil) {}
+
+  TestPaymentRequest(const web::PaymentRequest& web_payment_request,
                      autofill::PersonalDataManager* personal_data_manager)
       : TestPaymentRequest(web_payment_request,
                            nil,
@@ -54,6 +65,10 @@ class TestPaymentRequest : public PaymentRequest {
     region_data_loader_ = region_data_loader;
   }
 
+  void SetPrefService(PrefService* pref_service) {
+    pref_service_ = pref_service;
+  }
+
   void SetProfileComparator(
       payments::PaymentsProfileComparator* profile_comparator) {
     profile_comparator_ = profile_comparator;
@@ -79,6 +94,7 @@ class TestPaymentRequest : public PaymentRequest {
 
   // PaymentRequest
   autofill::RegionDataLoader* GetRegionDataLoader() override;
+  PrefService* GetPrefService() override;
   payments::PaymentsProfileComparator* profile_comparator() override;
 
  private:
@@ -86,6 +102,9 @@ class TestPaymentRequest : public PaymentRequest {
   autofill::RegionDataLoader* region_data_loader_;
 
   // Not owned and must outlive this object.
+  PrefService* pref_service_;
+
+  // Not owned and must outlive this object.
   payments::PaymentsProfileComparator* profile_comparator_;
 
   DISALLOW_COPY_AND_ASSIGN(TestPaymentRequest);