[Payment Request] Displays appropriate footer if first transaction completed

ios/chrome/browser/ui/payments/payment_request_mediator.mm

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Foundation/Foundation.h>
 
 #include "ios/chrome/browser/ui/payments/payment_request_mediator.h"
 
 #include "base/strings/sys_string_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "components/autofill/core/browser/autofill_data_util.h"
 #include "components/autofill/core/browser/autofill_profile.h"
 #include "components/autofill/core/browser/credit_card.h"
 #include "components/autofill/core/browser/field_types.h"
 #include "components/payments/core/currency_formatter.h"
+#include "components/payments/core/payment_prefs.h"
 #include "components/payments/core/strings_util.h"
-#include "components/signin/core/browser/signin_manager.h"
+#include "components/prefs/pref_service.h"
 #include "components/strings/grit/components_strings.h"
 #include "ios/chrome/browser/payments/payment_request.h"
 #include "ios/chrome/browser/payments/payment_request_util.h"
-#include "ios/chrome/browser/signin/signin_manager_factory.h"
 #import "ios/chrome/browser/ui/collection_view/cells/collection_view_detail_item.h"
 #import "ios/chrome/browser/ui/collection_view/cells/collection_view_footer_item.h"
 #import "ios/chrome/browser/ui/collection_view/cells/collection_view_item.h"
 #import "ios/chrome/browser/ui/payments/cells/autofill_profile_item.h"
 #import "ios/chrome/browser/ui/payments/cells/payment_method_item.h"
 #import "ios/chrome/browser/ui/payments/cells/payments_text_item.h"
 #import "ios/chrome/browser/ui/payments/cells/price_item.h"
 #include "ios/chrome/browser/ui/uikit_ui_util.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
@@ skipping 11 matching lines @@
 using ::payments::GetShippingOptionSectionString;
 using ::payment_request_util::GetEmailLabelFromAutofillProfile;
 using ::payment_request_util::GetNameLabelFromAutofillProfile;
 using ::payment_request_util::GetPhoneNumberLabelFromAutofillProfile;
 using ::payment_request_util::GetShippingAddressLabelFromAutofillProfile;
 using ::payment_request_util::GetShippingSectionTitle;
 }  // namespace
 
 @interface PaymentRequestMediator ()
 
-@property(nonatomic, assign) ios::ChromeBrowserState* browserState;
-
 // The PaymentRequest object owning an instance of web::PaymentRequest as
 // provided by the page invoking the Payment Request API. This is a weak
 // pointer and should outlive this class.
 @property(nonatomic, assign) PaymentRequest* paymentRequest;
 
 @end
 
 @implementation PaymentRequestMediator
 
 @synthesize totalValueChanged = _totalValueChanged;
-@synthesize browserState = _browserState;
 @synthesize paymentRequest = _paymentRequest;
 
-- (instancetype)initWithBrowserState:(ios::ChromeBrowserState*)browserState
-                      paymentRequest:(PaymentRequest*)paymentRequest {
-  DCHECK(browserState);
+- (instancetype)initWithPaymentRequest:(PaymentRequest*)paymentRequest {
   self = [super init];
   if (self) {
-    _browserState = browserState;
     _paymentRequest = paymentRequest;
   }
   return self;
 }
 
 #pragma mark - PaymentRequestViewControllerDataSource
 
 - (BOOL)canPay {
   return self.paymentRequest->selected_credit_card() != nullptr &&
          (self.paymentRequest->selected_shipping_option() != nullptr ||
@@ skipping 167 matching lines @@
         uppercaseStringWithLocale:[NSLocale currentLocale]];
   } else {
     item.accessoryType = MDCCollectionViewCellAccessoryDisclosureIndicator;
   }
   return item;
 }
 
 - (CollectionViewFooterItem*)footerItem {
   CollectionViewFooterItem* item = [[CollectionViewFooterItem alloc] init];
 
-  // TODO(crbug.com/602666): Find out if the first payment has completed.
-  BOOL firstPaymentCompleted = YES;
-  if (!firstPaymentCompleted) {
+  // If no transaction has been completed so far, choose which string to display
+  // as a function of the profile's signed in state. Otherwise, always show the
+  // same string.
+  bool firstTransactionCompleted =

[macourteau, 2017/07/05 14:10:36]

optional nit (personal preference): const bool

[Moe, 2017/07/05 16:01:47]

Done.

+      _paymentRequest->GetPrefService()->GetBoolean(
+          payments::kPaymentsFirstTransactionCompleted);
+  if (firstTransactionCompleted) {
     item.text = l10n_util::GetNSString(IDS_PAYMENTS_CARD_AND_ADDRESS_SETTINGS);
-  } else if ([[self authenticatedAccountName] length]) {
-    const base::string16 accountName =
-        base::SysNSStringToUTF16([self authenticatedAccountName]);
-    const std::string formattedString = l10n_util::GetStringFUTF8(
-        IDS_PAYMENTS_CARD_AND_ADDRESS_SETTINGS_SIGNED_IN, accountName);
-    item.text = base::SysUTF8ToNSString(formattedString);
   } else {
-    item.text = l10n_util::GetNSString(
-        IDS_PAYMENTS_CARD_AND_ADDRESS_SETTINGS_SIGNED_OUT);
+    const std::string email = _paymentRequest->GetAuthenticatedEmail();
+    if (!email.empty()) {
+      const std::string formattedString = l10n_util::GetStringFUTF8(
+          IDS_PAYMENTS_CARD_AND_ADDRESS_SETTINGS_SIGNED_IN,
+          base::UTF8ToUTF16(email));
+      item.text = base::SysUTF8ToNSString(formattedString);
+    } else {
+      item.text = l10n_util::GetNSString(
+          IDS_PAYMENTS_CARD_AND_ADDRESS_SETTINGS_SIGNED_OUT);
+    }
   }
   item.linkURL = GURL(kSettingsURL);
   return item;
 }
 
-#pragma mark - Helper methods
-
-// Returns the authenticated account name, or nil if user is not authenticated.
-- (NSString*)authenticatedAccountName {
-  const SigninManager* signinManager =
-      ios::SigninManagerFactory::GetForBrowserStateIfExists(self.browserState);
-  if (signinManager && signinManager->IsAuthenticated()) {
-    return base::SysUTF8ToNSString(
-        signinManager->GetAuthenticatedAccountInfo().email);
-  }
-  return nil;
-}
-
 @end