Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: third_party/WebKit/Source/bindings/modules/v8/BUILD.gn

Issue 2970003002: Add code generation for ConditionalFeatures bindings code (Closed)
Patch Set: Readability fixes Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/modules/v8/BUILD.gn
diff --git a/third_party/WebKit/Source/bindings/modules/v8/BUILD.gn b/third_party/WebKit/Source/bindings/modules/v8/BUILD.gn
index 64208a308887777d2c66d1574733e70c6c778722..28fbedfb346bb11313d743b41aa038d3ab738c25 100644
--- a/third_party/WebKit/Source/bindings/modules/v8/BUILD.gn
+++ b/third_party/WebKit/Source/bindings/modules/v8/BUILD.gn
@@ -48,6 +48,17 @@ idl_compiler("generate_bindings_modules_v8_partial_interfaces_for_testing") {
target_component = "modules"
}
+generate_conditional_features("bindings_modules_conditional_features") {
+ sources =
+ modules_idl_files + modules_global_constructors_generated_idl_files +
+ modules_dependency_idl_files
+ component = "Modules"
+ output_dir = bindings_modules_output_dir + "/v8"
+ deps = [
+ "//third_party/WebKit/Source/bindings/modules:modules_global_constructors_idls",
+ ]
+}
+
action("bindings_modules_v8_generated_init_partial") {
script = "$bindings_scripts_dir/generate_init_partial_interfaces.py"
@@ -82,9 +93,11 @@ blink_modules_sources("bindings_modules_impl") {
get_target_outputs(":generate_bindings_modules_v8_interfaces") +
get_target_outputs(":bindings_modules_impl_generated") +
get_target_outputs(":generate_bindings_modules_v8_partial_interfaces") +
- get_target_outputs(":bindings_modules_v8_generated_init_partial")
+ get_target_outputs(":bindings_modules_v8_generated_init_partial") +
+ get_target_outputs(":bindings_modules_conditional_features")
deps = [
+ ":bindings_modules_conditional_features",
":bindings_modules_v8_generated",
]

Powered by Google App Engine
This is Rietveld 408576698