Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/bindings/bindings_tests.py

Issue 2970003002: Add code generation for ConditionalFeatures bindings code (Closed)
Patch Set: Make code generation testable, add to bindings tests Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/bindings/bindings_tests.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/bindings/bindings_tests.py b/third_party/WebKit/Tools/Scripts/webkitpy/bindings/bindings_tests.py
index 0d3303ac9e90cc511df9f555aac41eb536d984e6..98d39a45d1c455eaebdffacb44fb2692e09916be 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/bindings/bindings_tests.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/bindings/bindings_tests.py
@@ -42,6 +42,7 @@ from code_generator_web_agent_api import CodeGeneratorWebAgentAPI
from compute_interfaces_info_individual import InterfaceInfoCollector
from compute_interfaces_info_overall import (compute_interfaces_info_overall,
interfaces_info)
+from generate_conditional_features import generate_conditional_features
from idl_compiler import (generate_bindings,
generate_union_type_containers,
generate_dictionary_impl,
@@ -342,6 +343,10 @@ def bindings_tests(output_directory, verbose, suppress_diff):
info_provider,
options,
dictionary_impl_filenames)
+ generate_conditional_features(
+ info_provider,
+ options,
+ [filename for filename in idl_filenames if filename not in dictionary_impl_filenames])
Yuki 2017/07/15 12:09:19 nit: 80 columns?
iclelland 2017/07/16 04:23:06 Done.
finally:
delete_cache_files()

Powered by Google App Engine
This is Rietveld 408576698