third_party/WebKit/Source/bindings/scripts/code_generator_web_agent_api.py - Issue 2970003002: Add code generation for ConditionalFeatures bindings code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/code_generator_web_agent_api.py

Issue 2970003002: Add code generation for ConditionalFeatures bindings code (Closed)

Patch Set: Clean up Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/scripts/code_generator_v8.py ('k') | third_party/WebKit/Source/bindings/scripts/generate_conditional_features.py » ('j') | third_party/WebKit/Source/bindings/scripts/generate_conditional_features.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/scripts/code_generator_web_agent_api.py

diff --git a/third_party/WebKit/Source/bindings/scripts/code_generator_web_agent_api.py b/third_party/WebKit/Source/bindings/scripts/code_generator_web_agent_api.py

index 96b76aa98107e8eaa98ef800b80dd87cadfcf248..011092415f89569385c0ef692d9eb7fe3e22f9dc 100644

--- a/third_party/WebKit/Source/bindings/scripts/code_generator_web_agent_api.py

+++ b/third_party/WebKit/Source/bindings/scripts/code_generator_web_agent_api.py

@@ -22,7 +22,7 @@ DOM classes to the Web Agents layer.

import os

import posixpath

-from code_generator import CodeGeneratorBase, render_template

+from code_generator import IDLCodeGeneratorBase, render_template

# TODO(dglazkov): Move TypedefResolver to code_generator.py

from code_generator_v8 import TypedefResolver

from name_style_converter import NameStyleConverter

@@ -234,10 +234,10 @@ class InterfaceContextBuilder(object):

return self.result

-class CodeGeneratorWebAgentAPI(CodeGeneratorBase):

+class CodeGeneratorWebAgentAPI(IDLCodeGeneratorBase):

def __init__(self, info_provider, cache_dir, output_dir):

- CodeGeneratorBase.__init__(self, MODULE_PYNAME, info_provider,

- cache_dir, output_dir)

+ IDLCodeGeneratorBase.__init__(self, MODULE_PYNAME, info_provider,

+ cache_dir, output_dir)

self.type_resolver = TypeResolver(info_provider.interfaces_info)

self.typedef_resolver = TypedefResolver(info_provider)