Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/BUILD.gn

Issue 2970003002: Add code generation for ConditionalFeatures bindings code (Closed)
Patch Set: Clean up Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/BUILD.gn
diff --git a/third_party/WebKit/Source/bindings/core/v8/BUILD.gn b/third_party/WebKit/Source/bindings/core/v8/BUILD.gn
index 8fd8ce000de85d0712799aaf5f213e3e2b615a98..568ec2512a7fa465296fbe22630b241d6a2a49c7 100644
--- a/third_party/WebKit/Source/bindings/core/v8/BUILD.gn
+++ b/third_party/WebKit/Source/bindings/core/v8/BUILD.gn
@@ -113,6 +113,20 @@ generated_core_callback_function_files = [
"$bindings_core_v8_output_dir/ResizeObserverCallback.h",
]
+generate_conditional_features("bindings_core_conditional_features") {
+ sources = core_idl_files + core_idl_with_modules_dependency_files +
+ core_global_constructors_generated_idl_files
+ global_objects_file = "$bindings_core_output_dir/GlobalObjectsCore.pickle"
+ component = "Core"
+ output_dir = bindings_core_output_dir + "/v8"
+ deps = [
+ "//third_party/WebKit/Source/bindings/core:core_global_constructors_idls",
+ "//third_party/WebKit/Source/bindings/core:core_global_objects",
+ "//third_party/WebKit/Source/bindings/core:interfaces_info_individual_core",
+ "//third_party/WebKit/Source/bindings/modules:interfaces_info",
+ ]
+}
+
if (is_win || use_jumbo_build) {
# On Windows Official release builds, we try to preserve symbol space.
bindings_core_generated_interface_files =
@@ -185,9 +199,11 @@ blink_core_sources("bindings_core_impl") {
_non_testing_sources = get_target_outputs(":bindings_core_impl_generated") -
generated_core_testing_dictionary_files -
generated_core_testing_callback_function_files
- sources = _non_testing_sources + bindings_core_generated_interface_files
+ sources = _non_testing_sources + bindings_core_generated_interface_files +
+ get_target_outputs(":bindings_core_conditional_features")
deps = [
+ ":bindings_core_conditional_features",
":bindings_core_v8_generated",
]
}

Powered by Google App Engine
This is Rietveld 408576698