Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: pkg/compiler/lib/src/universe/resolution_world_builder.dart

Issue 2969993002: Handle instance/super methods in js_model/model_test (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/universe/resolution_world_builder.dart
diff --git a/pkg/compiler/lib/src/universe/resolution_world_builder.dart b/pkg/compiler/lib/src/universe/resolution_world_builder.dart
index d8f97ba68d1b9516755f8a6d45c128dd6e6203a2..591012e10d9c94c10e51fbd17f0984dcecc8c715 100644
--- a/pkg/compiler/lib/src/universe/resolution_world_builder.dart
+++ b/pkg/compiler/lib/src/universe/resolution_world_builder.dart
@@ -354,7 +354,7 @@ abstract class ResolutionWorldBuilderBase
bool _closed = false;
ClosedWorld _closedWorldCache;
- FunctionSetBuilder _allFunctions;
+ final Set<MemberEntity> _liveInstanceMembers = new Set<MemberEntity>();
final Set<TypedefElement> _allTypedefs = new Set<TypedefElement>();
@@ -380,9 +380,7 @@ abstract class ResolutionWorldBuilderBase
this._nativeDataBuilder,
this._interceptorDataBuilder,
this._backendUsageBuilder,
- this.selectorConstraintsStrategy) {
- _allFunctions = new FunctionSetBuilder();
- }
+ this.selectorConstraintsStrategy);
Iterable<ClassEntity> get processedClasses => _processedClasses.keys
.where((cls) => _processedClasses[cls].isInstantiated);
@@ -787,7 +785,7 @@ abstract class ResolutionWorldBuilderBase
void registerUsedElement(MemberEntity element) {
if (element.isInstanceMember && !element.isAbstract) {
- _allFunctions.add(element);
+ _liveInstanceMembers.add(element);
}
}
@@ -977,7 +975,7 @@ abstract class KernelResolutionWorldBuilderBase
constantSystem: _constantSystem,
resolutionWorldBuilder: this,
implementedClasses: _implementedClasses,
- functionSet: _allFunctions.close(),
+ liveInstanceMembers: _liveInstanceMembers,
allTypedefs: _allTypedefs,
mixinUses: _mixinUses,
typesImplementedBySubclasses: typesImplementedBySubclasses,

Powered by Google App Engine
This is Rietveld 408576698