Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Unified Diff: pkg/compiler/lib/src/js_model/elements.dart

Issue 2969993002: Handle instance/super methods in js_model/model_test (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_model/elements.dart
diff --git a/pkg/compiler/lib/src/js_model/elements.dart b/pkg/compiler/lib/src/js_model/elements.dart
index 20094d98733d56ce8ee31832569e13171956704e..3efe0ad56b4df85400d660b22fb3fb9335898261 100644
--- a/pkg/compiler/lib/src/js_model/elements.dart
+++ b/pkg/compiler/lib/src/js_model/elements.dart
@@ -14,10 +14,10 @@ import '../js_backend/backend_usage.dart';
import '../js_backend/interceptor_data.dart';
import '../js_backend/native_data.dart';
import '../kernel/elements.dart';
+import '../kernel/element_map_impl.dart';
import '../native/behavior.dart';
import '../ordered_typeset.dart';
import '../universe/class_set.dart';
-import '../universe/function_set.dart';
import '../universe/selector.dart';
import '../universe/world_builder.dart';
import '../world.dart';
@@ -520,7 +520,7 @@ class JTypeVariable implements TypeVariableEntity {
'${jsElementPrefix}type_variable(${typeDeclaration.name}.$name)';
}
-class JsClosedWorld extends ClosedWorldBase {
+class JsClosedWorld extends ClosedWorldBase with KernelClosedWorldMixin {
JsClosedWorld(
{ElementEnvironment elementEnvironment,
DartTypes dartTypes,
@@ -531,28 +531,28 @@ class JsClosedWorld extends ClosedWorldBase {
BackendUsage backendUsage,
ResolutionWorldBuilder resolutionWorldBuilder,
Set<ClassEntity> implementedClasses,
- FunctionSet functionSet,
+ Iterable<MemberEntity> liveInstanceMembers,
Set<TypedefElement> allTypedefs,
Map<ClassEntity, Set<ClassEntity>> mixinUses,
Map<ClassEntity, Set<ClassEntity>> typesImplementedBySubclasses,
Map<ClassEntity, ClassHierarchyNode> classHierarchyNodes,
Map<ClassEntity, ClassSet> classSets})
: super(
- elementEnvironment: elementEnvironment,
- dartTypes: dartTypes,
- commonElements: commonElements,
- constantSystem: constantSystem,
- nativeData: nativeData,
- interceptorData: interceptorData,
- backendUsage: backendUsage,
- resolutionWorldBuilder: resolutionWorldBuilder,
- implementedClasses: implementedClasses,
- functionSet: functionSet,
- allTypedefs: allTypedefs,
- mixinUses: mixinUses,
- typesImplementedBySubclasses: typesImplementedBySubclasses,
- classHierarchyNodes: classHierarchyNodes,
- classSets: classSets);
+ elementEnvironment,
+ dartTypes,
+ commonElements,
+ constantSystem,
+ nativeData,
+ interceptorData,
+ backendUsage,
+ resolutionWorldBuilder,
+ implementedClasses,
+ liveInstanceMembers,
+ allTypedefs,
+ mixinUses,
+ typesImplementedBySubclasses,
+ classHierarchyNodes,
+ classSets);
@override
bool hasConcreteMatch(ClassEntity cls, Selector selector,
@@ -566,11 +566,6 @@ class JsClosedWorld extends ClosedWorldBase {
}
@override
- bool hasElementIn(ClassEntity cls, Selector selector, Entity element) {
- throw new UnimplementedError('JsClosedWorld.hasElementIn');
- }
-
- @override
bool checkEntity(Entity element) => true;
@override
« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_model/js_strategy.dart » ('j') | pkg/compiler/lib/src/js_model/js_strategy.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698