Handle instance/super methods in js_model/model_test

Handle instance/super methods in js_model/model_test

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/550b74233f8582b95c84a41cb689702812841f3c

[Johnni Winther, 2017-07-04 11:37:24]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-07-05 20:28:53]

lgtm

https://codereview.chromium.org/2969993002/diff/1/pkg/compiler/lib/src/js_mod...
File pkg/compiler/lib/src/js_model/js_strategy.dart (right):

https://codereview.chromium.org/2969993002/diff/1/pkg/compiler/lib/src/js_mod...
pkg/compiler/lib/src/js_model/js_strategy.dart:141: mixinUses: mixinUses,
is there more to this than what you have above?

https://codereview.chromium.org/2969993002/diff/1/pkg/compiler/lib/src/world....
File pkg/compiler/lib/src/world.dart (right):

https://codereview.chromium.org/2969993002/diff/1/pkg/compiler/lib/src/world....
pkg/compiler/lib/src/world.dart:456: this.elementEnvironment,
since we loose named arguments because of the new mixin, I wonder whether it is
worth it.

What if we include the default implementation here instead?

It is technically still correct and the Impl subclass below can still override
it so that it is optimized for the regular modelx element model.

https://codereview.chromium.org/2969993002/diff/1/pkg/compiler/lib/src/world....
pkg/compiler/lib/src/world.dart:465: this.liveInstanceMembers,
any reason why not create the FunctionSet eagerly here?

[Johnni Winther, 2017-07-06 14:14:46]

https://codereview.chromium.org/2969993002/diff/1/pkg/compiler/lib/src/js_mod...
File pkg/compiler/lib/src/js_model/js_strategy.dart (right):

https://codereview.chromium.org/2969993002/diff/1/pkg/compiler/lib/src/js_mod...
pkg/compiler/lib/src/js_model/js_strategy.dart:141: mixinUses: mixinUses,
On 2017/07/05 20:28:52, Siggi Cherem (dart-lang) wrote:
> is there more to this than what you have above?

No. Moved

https://codereview.chromium.org/2969993002/diff/1/pkg/compiler/lib/src/world....
File pkg/compiler/lib/src/world.dart (right):

https://codereview.chromium.org/2969993002/diff/1/pkg/compiler/lib/src/world....
pkg/compiler/lib/src/world.dart:456: this.elementEnvironment,
On 2017/07/05 20:28:52, Siggi Cherem (dart-lang) wrote:
> since we loose named arguments because of the new mixin, I wonder whether it
is
> worth it.
> 
> What if we include the default implementation here instead?
> 
> It is technically still correct and the Impl subclass below can still override
> it so that it is optimized for the regular modelx element model.

I want required named arguments - bad language!

https://codereview.chromium.org/2969993002/diff/1/pkg/compiler/lib/src/world....
pkg/compiler/lib/src/world.dart:465: this.liveInstanceMembers,
On 2017/07/05 20:28:52, Siggi Cherem (dart-lang) wrote:
> any reason why not create the FunctionSet eagerly here?

Yes. [FunctionSet] is created lazily because it is not used when we switch from
a frontend to a backend model before inference. Add a comment.

[Johnni Winther, 2017-07-06 14:16:57]

Description was changed from

==========
Handle instance/super methods in js_model/model_test
==========

to

==========
Handle instance/super methods in js_model/model_test

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/550b74233f8582b95c84a41cb689702812841f3c
==========

[Johnni Winther, 2017-07-06 14:16:59]

Committed patchset #1 (id:1) manually as
550b74233f8582b95c84a41cb689702812841f3c (presubmit successful).